From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1FC2313888F for ; Wed, 28 Oct 2015 14:56:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 169A421C001; Wed, 28 Oct 2015 14:56:49 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A050721C001 for ; Wed, 28 Oct 2015 14:56:48 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 9B75833BF44 for ; Wed, 28 Oct 2015 14:56:45 +0000 (UTC) Date: Wed, 28 Oct 2015 07:55:56 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 8/9] lint: convert type/types to isinstance Message-ID: <20151028075556.7e29cae0.dolsen@gentoo.org> In-Reply-To: <1444624562-26162-8-git-send-email-vapier@gentoo.org> References: <1444624562-26162-1-git-send-email-vapier@gentoo.org> <1444624562-26162-8-git-send-email-vapier@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: afd146e3-6d76-4ac2-97b9-0979e8f979b7 X-Archives-Hash: e064c2974e2bd7e77f7e2d0869b47af2 On Mon, 12 Oct 2015 00:36:01 -0400 Mike Frysinger wrote: > pylint complains about using (type(...) == types.xxx) checks as it > prefers isinstance(..., xxx) instead. Convert the code base to it. > --- > .pylintrc | 3 +-- > catalyst/base/stagebase.py | 57 > +++++++++++++++++---------------------- > catalyst/support.py | 3 +-- > catalyst/targets/grp.py | 5 ++-- > catalyst/targets/livecd_stage1.py | 5 ++-- > catalyst/targets/netboot.py | 9 +++---- > catalyst/targets/netboot2.py | 11 ++++---- 7 files changed, 39 > insertions(+), 54 deletions(-) > > looks good. Thanks, yet another task done that has been bugging me for quite a while. -- Brian Dolbec