public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Cc: Kevin Zhao <kevin.zhaoshuai@gmail.com>
Subject: Re: [gentoo-catalyst][PATCH  2/3] Modify the parameter of ppc64 little-endian, because the ppc64 little-endian has different archtecture and new boot parameters.Don't need the hfs and mapping files as it in Big-endian.Also tweak the code of Big-endian.
Date: Fri, 8 Jan 2016 14:50:42 -0500	[thread overview]
Message-ID: <20160108195042.GM25548@vapier.lan> (raw)
In-Reply-To: <1452247450-14865-1-git-send-email-kevin.zhaoshuai@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

On 08 Jan 2016 05:04, Kevin Zhao wrote:
> +		if echo ${clst_subarch} | grep -qE ".+le$"

just use a pattern match:
	if [[ ${clst_subarch} == *le ]]

> +		then
> +			flags+=(
> +				-v -T -l -cache-inodes -chrp-boot
> +			)

-chrp-boot shows up in both, so factor that out into the common setting ?

> +			flags+=(
> +				-chrp-boot -netatalk -hfs -probe -map "${clst_target_path}"/boot/map.hfs \ 

you don't need to use \ with arrays
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-01-08 19:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 10:03 [gentoo-catalyst][PATCH 1/3] Add a subarch ppc64le,is the little-endian of ppc64.Also add power7,power7le,power8le.The subarch power7 and power8 are inheriting from ppc64.Power7le and Power8le are inheriting from ppc64le.As the little-endian of ppc64, the ppc64le can be a keyword,it will be used in create iso and intergrating bootloader Kevin Zhao
2016-01-08 10:04 ` [gentoo-catalyst][PATCH 2/3] Modify the parameter of ppc64 little-endian, because the ppc64 little-endian has different archtecture and new boot parameters.Don't need the hfs and mapping files as it in Big-endian.Also tweak the code of Big-endian Kevin Zhao
2016-01-08 19:50   ` Mike Frysinger [this message]
2016-01-12 14:31     ` Kevin Zhao
2016-04-21  4:41       ` Leno Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160108195042.GM25548@vapier.lan \
    --to=vapier@gentoo.org \
    --cc=gentoo-catalyst@lists.gentoo.org \
    --cc=kevin.zhaoshuai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox