From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F33EB139694 for ; Sat, 11 Mar 2017 21:31:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 08BD3E0C02; Sat, 11 Mar 2017 21:31:36 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D12E3E0C02 for ; Sat, 11 Mar 2017 21:31:35 +0000 (UTC) Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id B552D3409C1 for ; Sat, 11 Mar 2017 21:31:34 +0000 (UTC) Date: Sat, 11 Mar 2017 16:31:34 -0500 From: Mike Frysinger To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 1/7] Move the signal handler into the StageBase class so it can handle unbind() cleanup Message-ID: <20170311213134.GD31094@vapier> Mail-Followup-To: gentoo-catalyst@lists.gentoo.org References: <20170310112237.022f9336.dolsen@gentoo.org> <20170310112247.1c8fff5d.dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J5MfuwkIyy7RmF4Q" Content-Disposition: inline In-Reply-To: <20170310112247.1c8fff5d.dolsen@gentoo.org> X-Archives-Salt: 8251f0f4-4539-4376-b86e-bd200bf880f2 X-Archives-Hash: 71f0fdc036ae577ca7f77c1016541460 --J5MfuwkIyy7RmF4Q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 10 Mar 2017 11:22, Brian Dolbec wrote: > Subject: [PATCH 1/7] Move the signal handler into the StageBase class so = it > can handle unbind() cleanup >=20 > Not quite complete, still errors on some unmounting i don't think moving signal handling into a random module makes sense. the main loop should be responsible for this business. i.e. where the code is now (or in catalyst._main). if the only thing you want to handle is clean up of mounts, then we should be looking at mount namespaces instead. unlike other namespaces, support for mount namespaces has been around forever and can't be turned off in the kernel. the releng repo deals with this by running everything through unshare. snakeoil already includes namespace support. i'll send a patch. -mike --J5MfuwkIyy7RmF4Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAljEbLYACgkQQWM7n+g3 9YHZ/Q/+K6s11kTYkiaOXfbPo816dJMYk3ZgoTYJw5JEWNboIbrj410uFcQHIyDv SDJZwrUNIjCUS+J3LRQPwZETybAT6GLuKksmdISW9WSJs6FNTjiFfwem/437kBxQ Zx4yj3fitUHEKZAcjzn39lyxGdWKpNQTliNZebUMVDQHmKnT1sMULMUI29V1exzJ T9a834bgxdu9ux2813KNRjWa0U3f3O9lHT4wxvtLbc0JMDkahfbZBTOIuVJhmhyR jBGQ2v8QHGZPA8UJ8o30StVQ9SmOvgqBMgkf3jKYkhkIZV/nITl4Pyke6b6IM2Nl PD9Px7phgY0wg3g+YQqmOpLW5LvZG4Cdm6mO84LgY6CGYTTlZNEggd+eZ5adoJul tcPGFIXfWN0PN16fUnj8B5lKcTkscNt33QR98mhSv2crl4RDtLRTCe4GNnecl4yj 0DIAbPkBDqSQEdtLcSW2i8qrRYss2GawG70ZAw2eCyS7ZzBNfu6kaerOhAKcNo3E 17Td3zt6fV8kBfJVddbhwAH4rU5Rm6sh7cUDuSbOuYOSYXnnAxebXwv9ccrdieyE 3zRwi3whE8h1FB94vOUCqxHyJ7hZz1ZdGhkAYXwr2gsmrDR67HZSgpAXjo4Kd0th tZsKb7CBh2X9VZ/qr0eNa/qPs1JSF89EgiTpszYjhFUkk243r4Q= =HU7R -----END PGP SIGNATURE----- --J5MfuwkIyy7RmF4Q--