public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH] catalyst: create namespaces for building
Date: Tue, 14 Mar 2017 13:14:52 -0700	[thread overview]
Message-ID: <20170314131452.65039245.dolsen@gentoo.org> (raw)
In-Reply-To: <20170311222238.24250-1-vapier@gentoo.org>

On Sat, 11 Mar 2017 14:22:38 -0800
Mike Frysinger <vapier@gentoo.org> wrote:

> This helps isolate the catalyst builds from the rest of the system
> and allows us to build as non-root user in more cases.
> 
> We don't support pid or user namespaces yet.
> ---
>  catalyst/main.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/catalyst/main.py b/catalyst/main.py
> index 51d2b04ab035..b8ae662dc76d 100644
> --- a/catalyst/main.py
> +++ b/catalyst/main.py
> @@ -12,6 +12,7 @@ import os
>  import sys
>  
>  from snakeoil import process
> +from snakeoil.process import namespaces
>  
>  from DeComp.definitions import (COMPRESS_DEFINITIONS,
> DECOMPRESS_DEFINITIONS, CONTENTS_DEFINITIONS)
> @@ -421,6 +422,14 @@ def _main(parser, opts):
>  		# catalyst cannot be run as a normal user due to
> chroots, mounts, etc log.critical('This script requires root
> privileges to operate') 
> +	# Start off by creating unique namespaces to run in.  Would
> be nice to
> +	# use pid & user namespaces, but snakeoil's namespace module
> has signal
> +	# transfer issues (CTRL+C doesn't propagate), and user
> namespaces need
> +	# more work due to Gentoo build process (uses
> sudo/root/portage).
> +	namespaces.simple_unshare(
> +		mount=True, uts=True, ipc=True, pid=False,
> net=False, user=False,
> +		hostname='catalyst')
> +
>  	# everything is setup, so the build is a go
>  	try:
>  		success = build_target(addlargs)

Thanks, looks good.  I'll nuke that other commit in the pending branch

-- 
Brian Dolbec <dolsen>



      reply	other threads:[~2017-03-14 20:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-11 22:22 [gentoo-catalyst] [PATCH] catalyst: create namespaces for building Mike Frysinger
2017-03-14 20:14 ` Brian Dolbec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170314131452.65039245.dolsen@gentoo.org \
    --to=dolsen@gentoo.org \
    --cc=gentoo-catalyst@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox