From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 4/8] targets: Remove unused source filesystem-functions.sh
Date: Sat, 2 May 2020 16:06:12 -0700 [thread overview]
Message-ID: <20200502160612.4bbefa7f@storm> (raw)
In-Reply-To: <20200502014036.1039317-4-mattst88@gentoo.org>
On Fri, 1 May 2020 18:40:32 -0700
Matt Turner <mattst88@gentoo.org> wrote:
> Signed-off-by: Matt Turner <mattst88@gentoo.org>
> ---
This one makes more sense if you had mentioned the previous commit that
inlined it.
Perhaps even merge the 2 commits into one
> targets/embedded/controller.sh | 1 -
> targets/livecd-stage2/controller.sh | 1 -
> targets/netboot/controller.sh | 1 -
> targets/support/bootloader-setup.sh | 1 -
> targets/support/create-iso.sh | 1 -
> targets/support/netboot-final.sh | 1 -
> 6 files changed, 6 deletions(-)
>
> diff --git a/targets/embedded/controller.sh
> b/targets/embedded/controller.sh index 7e33ed49..e40a913f 100755
> --- a/targets/embedded/controller.sh
> +++ b/targets/embedded/controller.sh
> @@ -1,7 +1,6 @@
> #!/bin/bash
>
> source ${clst_shdir}/support/functions.sh
> -source ${clst_shdir}/support/filesystem-functions.sh
>
> case ${1} in
> enter)
> diff --git a/targets/livecd-stage2/controller.sh
> b/targets/livecd-stage2/controller.sh index f9bc7b7e..8ee46d7c 100755
> --- a/targets/livecd-stage2/controller.sh
> +++ b/targets/livecd-stage2/controller.sh
> @@ -1,7 +1,6 @@
> #!/bin/bash
>
> source ${clst_shdir}/support/functions.sh
> -source ${clst_shdir}/support/filesystem-functions.sh
>
> case $1 in
> pre-kmerge)
> diff --git a/targets/netboot/controller.sh
> b/targets/netboot/controller.sh index d6b329e6..f84a32bd 100755
> --- a/targets/netboot/controller.sh
> +++ b/targets/netboot/controller.sh
> @@ -1,7 +1,6 @@
> #!/bin/bash
>
> source ${clst_shdir}/support/functions.sh
> -source ${clst_shdir}/support/filesystem-functions.sh
>
> case ${1} in
> build_packages)
> diff --git a/targets/support/bootloader-setup.sh
> b/targets/support/bootloader-setup.sh index 1564d74a..d507fe5e 100755
> --- a/targets/support/bootloader-setup.sh
> +++ b/targets/support/bootloader-setup.sh
> @@ -1,7 +1,6 @@
> #!/bin/bash
>
> source ${clst_shdir}/support/functions.sh
> -source ${clst_shdir}/support/filesystem-functions.sh
>
> # $1 is the destination root
>
> diff --git a/targets/support/create-iso.sh
> b/targets/support/create-iso.sh index 01b06501..e5ad7060 100755
> --- a/targets/support/create-iso.sh
> +++ b/targets/support/create-iso.sh
> @@ -1,7 +1,6 @@
> #!/bin/bash
>
> source ${clst_shdir}/support/functions.sh
> -source ${clst_shdir}/support/filesystem-functions.sh
>
> ## START RUNSCRIPT
>
> diff --git a/targets/support/netboot-final.sh
> b/targets/support/netboot-final.sh index 52b85f05..f71e4099 100755
> --- a/targets/support/netboot-final.sh
> +++ b/targets/support/netboot-final.sh
> @@ -1,7 +1,6 @@
> #!/bin/bash
>
> source ${clst_shdir}/support/functions.sh
> -source ${clst_shdir}/support/filesystem-functions.sh
>
> extract_kernels ${clst_target_path}/boot
>
next prev parent reply other threads:[~2020-05-02 23:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 1:40 [gentoo-catalyst] [PATCH 1/8] targets: Use gensquashfs instead of mksquashfs Matt Turner
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 2/8] targets: Drop most fstypes Matt Turner
2020-05-02 23:00 ` Brian Dolbec
2020-05-02 23:17 ` Matt Turner
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 3/8] targets: Inline filesystem-functions.sh Matt Turner
2020-05-02 23:03 ` Brian Dolbec
2020-05-02 23:18 ` Matt Turner
2020-05-03 0:25 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 4/8] targets: Remove unused source filesystem-functions.sh Matt Turner
2020-05-02 23:06 ` Brian Dolbec [this message]
2020-05-02 23:20 ` Matt Turner
2020-05-02 23:51 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 5/8] targets: Remove run_crossdev() function Matt Turner
2020-05-02 23:06 ` Brian Dolbec
2020-05-02 23:22 ` Matt Turner
2020-05-02 23:45 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 6/8] targets: Inline functions with one caller Matt Turner
2020-05-02 23:12 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 7/8] targets: Remove unused extract_kernel() Matt Turner
2020-05-02 23:15 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 8/8] catalyst: Replace target_portdir with repo_basedir+repo_name Matt Turner
2020-05-02 23:28 ` Brian Dolbec
2020-05-02 22:56 ` [gentoo-catalyst] [PATCH 1/8] targets: Use gensquashfs instead of mksquashfs Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200502160612.4bbefa7f@storm \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox