From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 72883138350 for ; Sat, 2 May 2020 23:06:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7A0DBE0AE2; Sat, 2 May 2020 23:06:15 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5F7D9E0AE2 for ; Sat, 2 May 2020 23:06:15 +0000 (UTC) Date: Sat, 2 May 2020 16:06:12 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 4/8] targets: Remove unused source filesystem-functions.sh Message-ID: <20200502160612.4bbefa7f@storm> In-Reply-To: <20200502014036.1039317-4-mattst88@gentoo.org> References: <20200502014036.1039317-1-mattst88@gentoo.org> <20200502014036.1039317-4-mattst88@gentoo.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 234fc4f0-e9cf-4108-955f-40fb27ba9202 X-Archives-Hash: 00fc7158782cbd03b8ab2accf2968a77 On Fri, 1 May 2020 18:40:32 -0700 Matt Turner wrote: > Signed-off-by: Matt Turner > --- This one makes more sense if you had mentioned the previous commit that inlined it. Perhaps even merge the 2 commits into one > targets/embedded/controller.sh | 1 - > targets/livecd-stage2/controller.sh | 1 - > targets/netboot/controller.sh | 1 - > targets/support/bootloader-setup.sh | 1 - > targets/support/create-iso.sh | 1 - > targets/support/netboot-final.sh | 1 - > 6 files changed, 6 deletions(-) > > diff --git a/targets/embedded/controller.sh > b/targets/embedded/controller.sh index 7e33ed49..e40a913f 100755 > --- a/targets/embedded/controller.sh > +++ b/targets/embedded/controller.sh > @@ -1,7 +1,6 @@ > #!/bin/bash > > source ${clst_shdir}/support/functions.sh > -source ${clst_shdir}/support/filesystem-functions.sh > > case ${1} in > enter) > diff --git a/targets/livecd-stage2/controller.sh > b/targets/livecd-stage2/controller.sh index f9bc7b7e..8ee46d7c 100755 > --- a/targets/livecd-stage2/controller.sh > +++ b/targets/livecd-stage2/controller.sh > @@ -1,7 +1,6 @@ > #!/bin/bash > > source ${clst_shdir}/support/functions.sh > -source ${clst_shdir}/support/filesystem-functions.sh > > case $1 in > pre-kmerge) > diff --git a/targets/netboot/controller.sh > b/targets/netboot/controller.sh index d6b329e6..f84a32bd 100755 > --- a/targets/netboot/controller.sh > +++ b/targets/netboot/controller.sh > @@ -1,7 +1,6 @@ > #!/bin/bash > > source ${clst_shdir}/support/functions.sh > -source ${clst_shdir}/support/filesystem-functions.sh > > case ${1} in > build_packages) > diff --git a/targets/support/bootloader-setup.sh > b/targets/support/bootloader-setup.sh index 1564d74a..d507fe5e 100755 > --- a/targets/support/bootloader-setup.sh > +++ b/targets/support/bootloader-setup.sh > @@ -1,7 +1,6 @@ > #!/bin/bash > > source ${clst_shdir}/support/functions.sh > -source ${clst_shdir}/support/filesystem-functions.sh > > # $1 is the destination root > > diff --git a/targets/support/create-iso.sh > b/targets/support/create-iso.sh index 01b06501..e5ad7060 100755 > --- a/targets/support/create-iso.sh > +++ b/targets/support/create-iso.sh > @@ -1,7 +1,6 @@ > #!/bin/bash > > source ${clst_shdir}/support/functions.sh > -source ${clst_shdir}/support/filesystem-functions.sh > > ## START RUNSCRIPT > > diff --git a/targets/support/netboot-final.sh > b/targets/support/netboot-final.sh index 52b85f05..f71e4099 100755 > --- a/targets/support/netboot-final.sh > +++ b/targets/support/netboot-final.sh > @@ -1,7 +1,6 @@ > #!/bin/bash > > source ${clst_shdir}/support/functions.sh > -source ${clst_shdir}/support/filesystem-functions.sh > > extract_kernels ${clst_target_path}/boot >