From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D2CF9138350 for ; Sat, 2 May 2020 23:16:13 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 13361E0AE4; Sat, 2 May 2020 23:16:13 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F0118E0AE4 for ; Sat, 2 May 2020 23:16:12 +0000 (UTC) Date: Sat, 2 May 2020 16:15:58 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 7/8] targets: Remove unused extract_kernel() Message-ID: <20200502161558.0a5def36@storm> In-Reply-To: <20200502014036.1039317-7-mattst88@gentoo.org> References: <20200502014036.1039317-1-mattst88@gentoo.org> <20200502014036.1039317-7-mattst88@gentoo.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 66f92f7b-3954-414f-bddd-3658573a8a7a X-Archives-Hash: c6e7eb9db5ccce1a80aa4f703d3180ac On Fri, 1 May 2020 18:40:35 -0700 Matt Turner wrote: > Evidently the answer to "Do we need this one?" is... not at least > since 2006. > > Signed-off-by: Matt Turner > --- works for me, but slightly more formal explanation would have been nicer. > targets/stage4/controller.sh | 2 -- > targets/support/functions.sh | 32 -------------------------------- > 2 files changed, 34 deletions(-) > > diff --git a/targets/stage4/controller.sh > b/targets/stage4/controller.sh index 85db8c1b..7ca3e9bc 100755 > --- a/targets/stage4/controller.sh > +++ b/targets/stage4/controller.sh > @@ -30,8 +30,6 @@ case $1 in > delete_from_chroot /tmp/linuxrc > > extract_modules ${clst_chroot_path} ${clst_kname} > - # Do we need this one? > -# extract_kernel ${clst_chroot_path}/boot > ${clst_kname} ;; > > build_packages) > diff --git a/targets/support/functions.sh > b/targets/support/functions.sh index ac6710ad..dd9e6b12 100755 > --- a/targets/support/functions.sh > +++ b/targets/support/functions.sh > @@ -184,35 +184,3 @@ extract_modules() { > echo "Can't find kernel modules tarball at > ${kmodules}. Skipping...." fi > } > -extract_kernel() { > - # $1 = Destination > - # $2 = kname > - > - > kbinary="${clst_chroot_path}/tmp/kerncache/${2}-kernel-initrd-${clst_version_stamp}.tar.bz2" > - [ ! -e "${kbinary}" ] && die "Can't find kernel tarball at > ${kbinary}" > - mkdir -p ${1}/ > - tar -I lbzip2 -xf ${kbinary} -C ${1}/ > - # change config name from "config-*" to "gentoo", for example > - #mv ${1}/config-* ${1}/${2}-config > - rm ${1}/config-* > - > - # change kernel name from "kernel" to "gentoo", for example > - if [ -e ${1}/kernel-* ] > - then > - mv ${1}/kernel-* ${1}/${2} > - fi > - if [ -e ${1}/vmlinuz-* ] > - then > - mv ${1}/vmlinuz-* ${1}/${2} > - fi > - > - # change initrd name from "initrd" to "gentoo.igz", for > example > - if [ -e ${1}/initrd-* ] > - then > - mv ${1}/initrd-* ${1}/${2}.igz > - fi > - if [ -e ${1}/initramfs-* ] > - then > - mv ${1}/initramfs-* ${1}/${2}.igz > - fi > -}