From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E79EC138350 for ; Sat, 2 May 2020 23:51:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 08BD5E081E; Sat, 2 May 2020 23:51:22 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D7814E081E for ; Sat, 2 May 2020 23:51:21 +0000 (UTC) Date: Sat, 2 May 2020 16:51:07 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 4/8] targets: Remove unused source filesystem-functions.sh Message-ID: <20200502165107.7faaa71f@storm> In-Reply-To: References: <20200502014036.1039317-1-mattst88@gentoo.org> <20200502014036.1039317-4-mattst88@gentoo.org> <20200502160612.4bbefa7f@storm> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 160aeac8-eca1-4c8d-bdb6-b712db7b492b X-Archives-Hash: ed8dc7c2f582f726de14ae1950a645af On Sat, 2 May 2020 16:20:31 -0700 Matt Turner wrote: > On Sat, May 2, 2020 at 4:06 PM Brian Dolbec wrote: > > > > On Fri, 1 May 2020 18:40:32 -0700 > > Matt Turner wrote: > > > > > Signed-off-by: Matt Turner > > > --- > > > > This one makes more sense if you had mentioned the previous commit > > that inlined it. > > > > Perhaps even merge the 2 commits into one > > This commit is fully independent of the previous. They do not touch > any of the same files. > yeah, my bad... my brain convieniently left out the word "source" from its understanding of the commit message. Now if it had said "Remove unused import..." my python would have kicked in, not confused the meaning...