From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C093D138350 for ; Sun, 3 May 2020 00:25:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 11279E092E; Sun, 3 May 2020 00:25:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F0017E092E for ; Sun, 3 May 2020 00:25:25 +0000 (UTC) Date: Sat, 2 May 2020 17:25:11 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 3/8] targets: Inline filesystem-functions.sh Message-ID: <20200502172511.73e45afb@storm> In-Reply-To: References: <20200502014036.1039317-1-mattst88@gentoo.org> <20200502014036.1039317-3-mattst88@gentoo.org> <20200502160342.3d3b05ca@storm> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: c64226b6-d365-41f1-9c8e-da673a7bb62a X-Archives-Hash: 61d42c27372b7407cd3df18290fa79b2 On Sat, 2 May 2020 16:18:43 -0700 Matt Turner wrote: > On Sat, May 2, 2020 at 4:03 PM Brian Dolbec wrote: > > > > On Fri, 1 May 2020 18:40:31 -0700 > > Matt Turner wrote: > > > > > Signed-off-by: Matt Turner > > > --- > > > > Again, no reasoning > > Sorry. I think it's pretty apparent. > > Simple functions that are called only from a single place and exist in > a different file should just be inlined. > > Should I just add that to the commit message? > No, like I commented in patch #6, list what was inlined. Was a poor choice of words on my part. The way your commit message are, you have to have the commits open in gitg or gitweb log view, or git log yyyyyyyyy to see the changes to know what was changed, or why. It is about readability. eg: # git log ... commit yyyyyyyyyyyyyyyyyyyyyyyyyyyyy Author: Matt Turner Date: Tue Apr 22 17:57:34 2020 -0700 targets: Inline functions with one caller commit xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx Author: Matt Turner Date: Tue Apr 21 17:57:34 2020 -0700 targets: Inline filesystem-functions.sh commit wwwwwwwwwwwwwwwwwwwwwwwwwwwwww Author: Matt Turner Date: Tue Apr 21 17:57:34 2020 -0700 targets: Drop most fstypes ================================================================== Better is ================================================================== commit yyyyyyyyyyyyyyyyyyyyyyyyyyyyy Author: Matt Turner Date: Tue Apr 22 17:57:34 2020 -0700 targets: Inline functions with one caller check_bootargs, check_filesystem_type were only used in bootloader_setup.sh commit xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx Author: Matt Turner Date: Tue Apr 21 17:57:34 2020 -0700 targets: Inline filesystem-functions.sh create_squashfs, create_jffs2 were only used in target_image_setup.sh commit wwwwwwwwwwwwwwwwwwwwwwwwwwwwww Author: Matt Turner Date: Tue Apr 21 17:57:34 2020 -0700 targets: Drop most fstypes drop ziofs, normal, noloop filesystem types They are old/obsolete/ no longer relavent...