From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DF8B61382C5 for ; Wed, 20 May 2020 22:47:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EB17EE086C; Wed, 20 May 2020 22:47:24 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B32B8E086C for ; Wed, 20 May 2020 22:47:24 +0000 (UTC) Date: Wed, 20 May 2020 15:47:20 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 13/21] catalyst: Remove support for source_matching="loose" Message-ID: <20200520154720.0f67f912@storm> In-Reply-To: <20200520034226.2870937-13-mattst88@gentoo.org> References: <20200520034226.2870937-1-mattst88@gentoo.org> <20200520034226.2870937-13-mattst88@gentoo.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: c1791ddd-d6f3-476a-a69f-2ed811c01f3f X-Archives-Hash: bd03ba11ce90c0719a8abd5841a0326e On Tue, 19 May 2020 20:42:18 -0700 Matt Turner wrote: > This does not seem like a useful feature to me. > > Signed-off-by: Matt Turner > --- > catalyst/base/stagebase.py | 3 --- > catalyst/defaults.py | 1 - > catalyst/support.py | 6 +++--- > etc/catalyst.conf | 12 ------------ > 4 files changed, 3 insertions(+), 19 deletions(-) > > diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py > index f39895fe..febaf969 100644 > --- a/catalyst/base/stagebase.py > +++ b/catalyst/base/stagebase.py > @@ -130,8 +130,6 @@ class StageBase(TargetBase, ClearBase, GenBase): > decomp_opt=self.settings["decomp_opt"]) > self.accepted_extensions = > self.decompressor.search_order_extensions( > self.settings["decompressor_search_order"]) > - log.notice("Source file specification matching setting is: > %s", > - self.settings["source_matching"]) > log.notice("Accepted source file extensions search order: > %s", self.accepted_extensions) > # save resources, it is not always needed > @@ -409,7 +407,6 @@ class StageBase(TargetBase, ClearBase, GenBase): > normpath(self.settings["storedir"] + "/builds/" + > self.settings["source_subpath"]), > self.accepted_extensions, > - self.settings["source_matching"] in ["strict"] > ) > log.debug('Source path returned from file_check is: %s', > self.settings["source_path"]) > diff --git a/catalyst/defaults.py b/catalyst/defaults.py > index 412cb956..14f671fe 100644 > --- a/catalyst/defaults.py > +++ b/catalyst/defaults.py > @@ -45,7 +45,6 @@ confdefaults = { > "repos": "%(storedir)s/repos", > "sharedir": "/usr/share/catalyst", > "shdir": "%(sharedir)s/targets", > - "source_matching": "strict", > "storedir": "/var/tmp/catalyst", > "target_distdir": "/var/cache/distfiles", > "target_pkgdir": "/var/cache/binpkgs", > diff --git a/catalyst/support.py b/catalyst/support.py > index c4a5c797..a6a6854a 100644 > --- a/catalyst/support.py > +++ b/catalyst/support.py > @@ -59,7 +59,7 @@ def cmd(mycmd, env=None, debug=False, > fail_func=None): print_traceback=False) > > > -def file_check(filepath, extensions=None, strict=True): > +def file_check(filepath, extensions=None): > '''Check for the files existence and that only one exists > if others are found with various extensions > ''' > @@ -73,8 +73,8 @@ def file_check(filepath, extensions=None, > strict=True): ".CONTENTS") and not x.endswith(".CONTENTS.gz") and not > x.endswith(".DIGESTS")] if len(files) == 1: > return files[0] > - if len(files) > 1 and strict: > - msg = "Ambiguos Filename: %s\nPlease specify the correct > extension as well" % filepath > + if len(files) > 1: > + msg = "Ambiguous Filename: %s\nPlease specify the correct > extension as well" % filepath raise CatalystError(msg, > print_traceback=False) target_file = None > for ext in extensions: I find this strict/loose option useful for testing various changes. I have my config set to loose. That way I can change compressors at will without changing spec file or deleting files, or editing the spec to specify the extension. While I find it useful. It may not be for most users. I would be ok with this if the others agree. Otherwise, this is not complex code to maintain. In fact is barely any code at all. > diff --git a/etc/catalyst.conf b/etc/catalyst.conf > index f64fe971..d33be15f 100644 > --- a/etc/catalyst.conf > +++ b/etc/catalyst.conf > @@ -50,18 +50,6 @@ envscript="/etc/catalyst/catalystrc" > # (These options can be used together) > options="autoresume bindist kerncache pkgcache seedcache" > > -# source_matching specifies how catalyst will match non-specific > file names -# if the filename is not found as an exact match. > -# ie: a filename without the extension specified. "/path/to/foo" > -# > -# possible values are: > -# "strict" meaning if more than one file of that name is present > with any -# file extension, then it will raise an > exception. -# "loose" meaning it will search for an existing > filename with an added -# extension from an ordered list > of extensions determined from the -# > decompressor_search_order specification in the spec file or (default) > -source_matching="strict" - > # port_logdir is where all build logs will be kept. This dir will be > automatically cleaned # of all logs over 30 days old. If left > undefined the logs will remain in the build directory # as usual and > get cleaned every time a stage build is restarted.