From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 474A01381F3 for ; Wed, 20 May 2020 22:59:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2FA83E09C7; Wed, 20 May 2020 22:59:23 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 14D59E09C7 for ; Wed, 20 May 2020 22:59:22 +0000 (UTC) Date: Wed, 20 May 2020 15:59:19 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] Re: [PATCH] targets: Don't delete pyc/pyo files Message-ID: <20200520155919.59468f92@storm> In-Reply-To: References: <20200516232939.2709013-1-mattst88@gentoo.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 2516525c-d743-432a-9348-1046410c9c40 X-Archives-Hash: 5bfc28fced30ec484e755189e13e9d4c On Sat, 16 May 2020 17:38:19 -0700 Matt Turner wrote: > On Sat, May 16, 2020 at 4:29 PM Matt Turner > wrote: > > > > These files are actually owned by their packages now, and removing > > them can break subsequent builds. > > > > See > > https://archives.gentoo.org/gentoo-releng-autobuilds/message/a115781f8e7fb4bd5adfb94a7f2e63b4 > > > > Signed-off-by: Matt Turner > > --- > > I'm minimally concerned about the potential for increasing the size > > of the ISO. I'll report back with numbers. > > > > targets/livecd-stage1/controller.sh | 4 ---- > > targets/livecd-stage2/controller.sh | 2 -- > > targets/stage1/preclean-chroot.sh | 2 -- > > 3 files changed, 8 deletions(-) > > > > diff --git a/targets/livecd-stage1/controller.sh > > b/targets/livecd-stage1/controller.sh index ced2634e..c4572ff9 > > 100755 --- a/targets/livecd-stage1/controller.sh > > +++ b/targets/livecd-stage1/controller.sh > > @@ -13,9 +13,5 @@ case $1 in > > ${clst_shdir}/${clst_target}/chroot.sh > > echo "${clst_packages}" > > > ${clst_chroot_path}/tmp/packages.txt ;; > > - > > - clean) > > - find ${clst_chroot_path}/usr/lib -iname "*.pyc" > > -exec rm -f {} \; > > - ;; > > esac > > exit $? > > diff --git a/targets/livecd-stage2/controller.sh > > b/targets/livecd-stage2/controller.sh index 8ee46d7c..0701a26b > > 100755 --- a/targets/livecd-stage2/controller.sh > > +++ b/targets/livecd-stage2/controller.sh > > @@ -85,8 +85,6 @@ case $1 in > > then > > # Clean out man, info and doc files > > rm -rf > > ${clst_chroot_path}/usr/share/{man,doc,info}/* > > - # Zap all .pyc and .pyo files > > - find ${clst_chroot_path}/usr/lib* -iname > > "*.py[co]" -exec rm -f {} \; > > I think we may want to keep this intact for livecd-stage2. The ISO > sizes goes from 286M to 305M. > > What do other people think? > Does anyone actually burn CD's anymore? Rarely I think. I stopped putting in a CD/DVD drive in systems years ago. If I did need to, I have several on older machines I can use along with a bunch of unused blanks. USB sticks are so cheap and much easier to use with a lot more space to even be able to emerge addtional pkgs on that the livedvd image enables. You can get a 5pak of 16gb drives for $20. 5pak of 8GB are $15 or less... I wouldn't worry about a few extra bytes to download.