From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 099A8138359 for ; Wed, 21 Oct 2020 03:02:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0E73FE0AD6; Wed, 21 Oct 2020 03:02:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EBCE1E0AD6 for ; Wed, 21 Oct 2020 03:02:03 +0000 (UTC) Date: Tue, 20 Oct 2020 23:01:49 -0400 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 02/37] catalyst: Drop outdated comment Message-ID: <20201020220229.205aa9b1@rogue1> In-Reply-To: <20201021002344.378131-2-mattst88@gentoo.org> References: <20201021002344.378131-1-mattst88@gentoo.org> <20201021002344.378131-2-mattst88@gentoo.org> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: abdb747d-798b-4ee1-a1df-090a67860975 X-Archives-Hash: aaa46abf652587615137df68f63f1a7f On Tue, 20 Oct 2020 17:23:09 -0700 Matt Turner wrote: > We don't use os.system anymore. We pass self.env to Popen, so the > comment isn't accurate. >=20 > Signed-off-by: Matt Turner > --- > catalyst/base/stagebase.py | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py > index 48157837..532f7133 100644 > --- a/catalyst/base/stagebase.py > +++ b/catalyst/base/stagebase.py > @@ -1307,11 +1307,6 @@ class StageBase(TargetBase, ClearBase, > GenBase): print_traceback=3DFalse) > =20 > def setup_environment(self): > - """ > - Modify the current environment. This is an ugly hack that > should be > - fixed. We need this to use the os.system() call since we > can't > - specify our own environ > - """ > log.debug('setup_environment(); settings =3D %r', > self.settings) for x in list(self.settings): > log.debug('setup_environment(); processing: %s', x) Instead of deleting the entire docstring, change it to reflect the correct info. =E2=80=8Cpylint will bitch about the lack of a docstring.