From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A793C138359 for ; Wed, 21 Oct 2020 00:24:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C46C7E0A10; Wed, 21 Oct 2020 00:24:01 +0000 (UTC) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BCC49E0A10 for ; Wed, 21 Oct 2020 00:24:01 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id y14so391920pfp.13 for ; Tue, 20 Oct 2020 17:24:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lLfg6FCBKKNiucTd4S056wb2AIlAZ0pKDaVvCkARKf4=; b=E5C3lLq7dbA5SAzRfvZfxL3DR80ElZKT2CE4CakNWxSjvB5WY1QEPRXfM2O093cCvD yYf7NRQZIFf/Q4PhvvJXWl5atCrLCPFWhZYSv+q7zMmTYvnlOkmQzaOG/UXLLMzP5W9b XCDV3+f2kHNeok58+Ehk2/mS3H2hVR4E2pCeGGAPQ9k3nuHhrjgjpCo04hr8o+fqLmUu +CtpGWFPt1jNvW05nIO68M/+nfP5OCKerqLKUGPZDdIhRq602VAhtiErF8ABJt4VFPGw +9AhnEBy3Vk5sIRF7VwCSU6egeCvpyJJ7HqUCOWKVUKmptpiQbGakX8SvxU7LRf/wbcG FY/A== X-Gm-Message-State: AOAM5309ex25o7jUSrOSNZgUmOv1OdtgyWH6RJeZB/CgaA5a7EvjD9jI VRJzS4xJrI/Ajh6q0V/nBwHmmnVDPFJH+w== X-Google-Smtp-Source: ABdhPJylyzi5NhYIhCMtyc+698hGTIas/eNFZKEsexahiL45gwAm2rxcoAftdjmHe3bW7dSubjiYvg== X-Received: by 2002:a63:b23:: with SMTP id 35mr737577pgl.116.1603239840354; Tue, 20 Oct 2020 17:24:00 -0700 (PDT) Received: from localhost ([108.161.26.224]) by smtp.gmail.com with ESMTPSA id p16sm188342pfq.63.2020.10.20.17.23.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 17:23:59 -0700 (PDT) From: Matt Turner To: gentoo-catalyst@lists.gentoo.org Cc: Matt Turner Subject: [gentoo-catalyst] [PATCH 02/37] catalyst: Drop outdated comment Date: Tue, 20 Oct 2020 17:23:09 -0700 Message-Id: <20201021002344.378131-2-mattst88@gentoo.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201021002344.378131-1-mattst88@gentoo.org> References: <20201021002344.378131-1-mattst88@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: 3ec0ca6f-209e-4154-9fb6-740aed1930a3 X-Archives-Hash: 9e54d6089fd93dd26cb40673b3f82442 We don't use os.system anymore. We pass self.env to Popen, so the comment isn't accurate. Signed-off-by: Matt Turner --- catalyst/base/stagebase.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py index 48157837..532f7133 100644 --- a/catalyst/base/stagebase.py +++ b/catalyst/base/stagebase.py @@ -1307,11 +1307,6 @@ class StageBase(TargetBase, ClearBase, GenBase): print_traceback=False) def setup_environment(self): - """ - Modify the current environment. This is an ugly hack that should be - fixed. We need this to use the os.system() call since we can't - specify our own environ - """ log.debug('setup_environment(); settings = %r', self.settings) for x in list(self.settings): log.debug('setup_environment(); processing: %s', x) -- 2.26.2