From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Cc: Matt Turner <mattst88@gentoo.org>
Subject: [gentoo-catalyst] [PATCH 2/5] targets: Make ${buildpkgs} an array
Date: Tue, 15 Dec 2020 22:01:28 -0500 [thread overview]
Message-ID: <20201216030131.14158-2-mattst88@gentoo.org> (raw)
In-Reply-To: <20201216030131.14158-1-mattst88@gentoo.org>
Signed-off-by: Matt Turner <mattst88@gentoo.org>
---
targets/stage1/chroot.sh | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/targets/stage1/chroot.sh b/targets/stage1/chroot.sh
index dac52dfc..7e8d5b4e 100755
--- a/targets/stage1/chroot.sh
+++ b/targets/stage1/chroot.sh
@@ -3,7 +3,7 @@
source /tmp/chroot-functions.sh
# We do this first, so we know our package list for --debug
-buildpkgs="$(/tmp/build.py)"
+buildpkgs=($(/tmp/build.py))
# Setup our environment
[ -n "${clst_BINDIST}" ] && BINDIST="bindist"
@@ -12,8 +12,7 @@ BOOTSTRAP_USE="$(portageq envvar BOOTSTRAP_USE)"
FEATURES="${FEATURES} nodoc noman noinfo"
## Sanity check profile
-if [ -z "${buildpkgs}" ]
-then
+if [[ ${#buildpkgs[@]} -eq 0 ]]; then
echo "Your profile seems to be broken."
echo "Could not build a list of build packages."
echo "Double check your ${clst_port_conf}/make.profile link and the 'packages' files."
@@ -72,7 +71,7 @@ if [ -e ${clst_make_conf} ]; then
done
fi
-run_merge "--oneshot ${buildpkgs}"
+run_merge "--oneshot ${buildpkgs[@]}"
# TODO: Drop this when locale-gen in stable glibc supports ROOT.
#
--
2.26.2
next prev parent reply other threads:[~2020-12-16 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 3:01 [gentoo-catalyst] [PATCH 1/5] targets: Rename clst_buildpkgs -> buildpkgs Matt Turner
2020-12-16 3:01 ` Matt Turner [this message]
2020-12-16 3:01 ` [gentoo-catalyst] [PATCH 3/5] targets: Move ${buildpkgs} error checking closer Matt Turner
2020-12-16 3:01 ` [gentoo-catalyst] [PATCH 4/5] targets: Use interpreter with portage module for build.py Matt Turner
2020-12-16 3:01 ` [gentoo-catalyst] [PATCH 5/5] catalyst: Remove dead comment Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216030131.14158-2-mattst88@gentoo.org \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox