From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Cc: Matt Turner <mattst88@gentoo.org>
Subject: [gentoo-catalyst] [PATCH 2/4] catalyst: Use lazy % formatting in logging functions
Date: Sun, 24 Jan 2021 10:07:20 -0500 [thread overview]
Message-ID: <20210124150722.760520-2-mattst88@gentoo.org> (raw)
In-Reply-To: <20210124150722.760520-1-mattst88@gentoo.org>
Signed-off-by: Matt Turner <mattst88@gentoo.org>
---
catalyst/base/stagebase.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
index 676206ff..badcfefa 100644
--- a/catalyst/base/stagebase.py
+++ b/catalyst/base/stagebase.py
@@ -823,7 +823,7 @@ class StageBase(TargetBase, ClearBase, GenBase):
repo_conf_chroot = self.to_chroot(repo_conf)
repo_conf_chroot.parent.mkdir(mode=0o755, parents=True, exist_ok=True)
- log.info(f'Creating repo config {repo_conf_chroot}.')
+ log.info('Creating repo config %s.', repo_conf_chroot)
try:
with open(repo_conf_chroot, 'w') as f:
@@ -846,10 +846,10 @@ class StageBase(TargetBase, ClearBase, GenBase):
location_chroot = self.to_chroot(location)
location_chroot.mkdir(mode=0o755, parents=True, exist_ok=True)
- log.info(f'Copying overlay dir {x} to {location_chroot}')
+ log.info('Copying overlay dir %s to %s', x, location_chroot)
cmd(f'cp -a {x}/* {location_chroot}', env=self.env)
else:
- log.warning(f'Skipping missing overlay {x}.')
+ log.warning('Skipping missing overlay %s.', x)
def root_overlay(self):
""" Copy over the root_overlay """
--
2.26.2
next prev parent reply other threads:[~2021-01-24 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 15:07 [gentoo-catalyst] [PATCH 1/4] catalyst: Remove unused import Matt Turner
2021-01-24 15:07 ` Matt Turner [this message]
2021-01-24 15:07 ` [gentoo-catalyst] [PATCH 3/4] catalyst: Remove fallback make.conf parsing code Matt Turner
2021-01-24 15:07 ` [gentoo-catalyst] [PATCH 4/4] catalyst: Clean up exception handling Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124150722.760520-2-mattst88@gentoo.org \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox