From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 89ADA15808D for ; Thu, 21 Apr 2022 07:08:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A43ABE08F1; Thu, 21 Apr 2022 07:08:49 +0000 (UTC) Received: from rs234.mailgun.us (rs234.mailgun.us [209.61.151.234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 836EEE08F1 for ; Thu, 21 Apr 2022 07:08:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=0xdc.io; q=dns/txt; s=smtp; t=1650524929; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-Id: Date: Subject: Subject: To: To: From: From: Sender: Sender; bh=r3WECTVGiY6wd9i22Ingy/3DQT8/2sBLXzWi8wsu6qo=; b=XBWXysIFm0m+TDBN7dyi3fJUnV359M0jt061z6PHAK3G5QNEQ9S3CfvTd3y8ZD6a3sOxzfv9 noMC0EmfCNLbH0du+2W+jFCd514IUHMblac4C9kDwPn66tlTK1OGB454Mls4s8EKgO0l8bnr G6566k9/gozeAvMXRQgZ6gZRVng= X-Mailgun-Sending-Ip: 209.61.151.234 X-Mailgun-Sid: WyJiZmIxMyIsICJnZW50b28tY2F0YWx5c3RAbGlzdHMuZ2VudG9vLm9yZyIsICJmNjc0NGUiXQ== Received: from mail.0xdc.io (mail.0xdc.io [54.37.0.172]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 62610301225c469082b93714 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 21 Apr 2022 07:08:49 GMT Sender: gentoo.catalyst@0xdc.io Received: from pulsar (5.b.0.d.c.4.e.f.f.f.1.0.5.8.8.4.0.a.4.7.9.0.c.0.0.b.8.0.1.0.0.2.ip6.arpa [IPv6:2001:8b0:c09:74a0:4885:1ff:fe4c:d0b5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.0xdc.io (Postfix) with ESMTPSA id 070F8102418 for ; Thu, 21 Apr 2022 07:10:39 +0000 (UTC) From: Daniel Cordero To: gentoo-catalyst@lists.gentoo.org Subject: [gentoo-catalyst] [PATCH 2/4] stage4/groups: don't run split on a list Date: Thu, 21 Apr 2022 07:08:24 +0000 Message-Id: <20220421070826.92638-2-gentoo.catalyst@0xdc.io> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220421070826.92638-1-gentoo.catalyst@0xdc.io> References: <20220421070826.92638-1-gentoo.catalyst@0xdc.io> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: eeb52822-884b-40e9-b390-1822c39786b7 X-Archives-Hash: 0d54e018b3816813f4db7bd670a859d6 "groups" has been normalised into a list and does not have a split() method. This fixes an issue introduced in commit 5be6069bcbd5a7fa3f114f28366597bc5ddbb891. --- catalyst/base/stagebase.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py index 1d71c59d..7e6b9e32 100644 --- a/catalyst/base/stagebase.py +++ b/catalyst/base/stagebase.py @@ -931,7 +931,7 @@ class StageBase(TargetBase, ClearBase, GenBase): env=self.env) def groups(self): - for x in self.settings["groups"].split(): + for x in self.settings["groups"]: log.notice("Creating group: '%s'", x) cmd(["groupadd", "-R", self.settings['chroot_path'], x], env=self.env) -- 2.35.1