[gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments

[gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments

[Daniel Cordero]

From: Daniel Cordero <catalyst@0xdc.io>

When enclosed in quotes and expanded with "${variable[@]}", the word is expanded
to be a single argument, rather than two separate arguments.

i.e. argv[2] = "-iso-level 3"
instead of
  argv[2] = "-iso-level"
  argv[3] = "3"

This lead to the failure:
  xorriso : FAILURE : -as mkisofs: Unrecognized option '-iso-level 3'
  xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
  grub-mkrescue: error: `xorriso` invocation failed

This patch fixes commit 0b56dbe4d36c88b0b051d24451e15cd6b64c819d.
---
 targets/support/create-iso.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
index 45ef1696..9991b930 100755
--- a/targets/support/create-iso.sh
+++ b/targets/support/create-iso.sh
@@ -194,7 +194,7 @@ case ${clst_hostarch} in
 	amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86)
 		isoroot_checksum
 
-		extra_opts=("-joliet" "-iso-level 3")
+		extra_opts=("-joliet" "-iso-level" "3")
 		case ${clst_hostarch} in
 		sparc*) extra_opts+=("--sparc-boot") ;;
 		esac
-- 
2.35.1

Re: [gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments

[Matt Turner]

Thanks, committed!

Re: [gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments

[Andreas K. Huettel]

Huh... fine of course and sorry about that.
Strange that it worked though...

Am Dienstag, 19. April 2022, 19:40:15 CEST schrieb Daniel Cordero:
> From: Daniel Cordero <catalyst@0xdc.io>
> 
> When enclosed in quotes and expanded with "${variable[@]}", the word is expanded
> to be a single argument, rather than two separate arguments.
> 
> i.e. argv[2] = "-iso-level 3"
> instead of
>   argv[2] = "-iso-level"
>   argv[3] = "3"
> 
> This lead to the failure:
>   xorriso : FAILURE : -as mkisofs: Unrecognized option '-iso-level 3'
>   xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
>   grub-mkrescue: error: `xorriso` invocation failed
> 
> This patch fixes commit 0b56dbe4d36c88b0b051d24451e15cd6b64c819d.
> ---
>  targets/support/create-iso.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
> index 45ef1696..9991b930 100755
> --- a/targets/support/create-iso.sh
> +++ b/targets/support/create-iso.sh
> @@ -194,7 +194,7 @@ case ${clst_hostarch} in
>  	amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86)
>  		isoroot_checksum
>  
> -		extra_opts=("-joliet" "-iso-level 3")
> +		extra_opts=("-joliet" "-iso-level" "3")
>  		case ${clst_hostarch} in
>  		sparc*) extra_opts+=("--sparc-boot") ;;
>  		esac
> 


-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)