[gentoo-catalyst] [PATCH] bootloader-setup.sh: remove obsolete cmdline args

[gentoo-catalyst] [PATCH] bootloader-setup.sh: remove obsolete cmdline args

[Ben Kohler]

These haven't been needed since kernel 2.4 days, as far as I know.

Signed-off-by: Ben Kohler <bkohler@gentoo.org>
---
 targets/support/bootloader-setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/targets/support/bootloader-setup.sh b/targets/support/bootloader-setup.sh
index 065f2bb5..32d86028 100755
--- a/targets/support/bootloader-setup.sh
+++ b/targets/support/bootloader-setup.sh
@@ -53,7 +53,7 @@ memtest_grub() {
   fi
 }
 
-default_append_line=(root=/dev/ram0 init=/linuxrc ${cmdline_opts[@]} cdroot)
+default_append_line=(${cmdline_opts[@]} cdroot)
 
 case ${clst_hostarch} in
 	alpha)
-- 
2.40.0

Re: [gentoo-catalyst] [PATCH] bootloader-setup.sh: remove obsolete cmdline args

[Matt Turner]

On Wed, Mar 29, 2023 at 4:14 PM Ben Kohler <bkohler@gentoo.org> wrote:
>
> These haven't been needed since kernel 2.4 days, as far as I know.
>
> Signed-off-by: Ben Kohler <bkohler@gentoo.org>
> ---
>  targets/support/bootloader-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/targets/support/bootloader-setup.sh b/targets/support/bootloader-setup.sh
> index 065f2bb5..32d86028 100755
> --- a/targets/support/bootloader-setup.sh
> +++ b/targets/support/bootloader-setup.sh
> @@ -53,7 +53,7 @@ memtest_grub() {
>    fi
>  }
>
> -default_append_line=(root=/dev/ram0 init=/linuxrc ${cmdline_opts[@]} cdroot)
> +default_append_line=(${cmdline_opts[@]} cdroot)
>
>  case ${clst_hostarch} in
>         alpha)
> --
> 2.40.0

Looks like we add 'root=/dev/ram0 init=/linuxrc' a few lines below in
the alpha-specific path as well. I wonder if we should drop it from
there too?

Otherwise, looks good to me.

Re: [gentoo-catalyst] [PATCH] bootloader-setup.sh: remove obsolete cmdline args

[Ben Kohler]

On 3/30/23 07:56, Matt Turner wrote:
> Looks like we add 'root=/dev/ram0 init=/linuxrc' a few lines below in
> the alpha-specific path as well. I wonder if we should drop it from
> there too?
>
> Otherwise, looks good to me.

I was a little hesitant to touch those since I don't know anything about 
alpha or netboot specifics.  But as I understand it, root=/dev/ram0 is 
only useful for actual initial *ramdisk* setups, in kernel 2.4 days, so 
surely it can just be removed.

I'll poke the alpha folks to be sure, then remove these as well.

-Ben