From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8E05A13827E for ; Sat, 14 Dec 2013 04:59:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 88F5FE0A64; Sat, 14 Dec 2013 04:59:37 +0000 (UTC) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id ECBE7E0A64 for ; Sat, 14 Dec 2013 04:59:36 +0000 (UTC) Received: by mail-pa0-f42.google.com with SMTP id lj1so860190pab.29 for ; Fri, 13 Dec 2013 20:59:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=rUFbi4b2GwZDI5xnNjkEXy/CMvY/ySpDcmwSZ9wknOI=; b=IgJbq1kZ6V1UitDIjW8AEVPtUsHtqGiFLLATI2zRlv+y/b4XuTwjyBVWBJDmst5ryN 1chjpr5e+zz08YosrXsZON1XDnfwrWm2AvYaOqVR6QmKPWTKYSs6aFFTk5ke57cripr3 H018ywZw0KTTqdgOCL0s8sIWWwYFpTrQgEBc3AqLzjNJENhYOpyDxSAIsiC7pk0LJLr1 zmyNSv1tZeFzlwCEdQOgf9A+whgjvFIPS+yGEKjzj4MBLdpx+Mon92EyHpVfPV845ZN6 tFOXtlPot3a4OvxmeHebOdMhnP6sjyMnCCkEHk/lu8S3Y7PmUoWttAhxhKBkoQZevaoM GGuQ== X-Received: by 10.66.197.135 with SMTP id iu7mr7333237pac.149.1386997175816; Fri, 13 Dec 2013 20:59:35 -0800 (PST) Received: from [172.31.0.8] (cpe-75-87-80-46.kc.res.rr.com. [75.87.80.46]) by mx.google.com with ESMTPSA id g6sm12375462pat.2.2013.12.13.20.59.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Dec 2013 20:59:35 -0800 (PST) Message-ID: <52ABE5AF.7090209@gmail.com> Date: Fri, 13 Dec 2013 22:59:27 -0600 From: "Dustin C. Hatch" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 3/4] Adapt commit c52962b6bd2 to use the new configured settings values. References: <1386990436-9198-1-git-send-email-dolsen@gentoo.org> <1386990436-9198-4-git-send-email-dolsen@gentoo.org> In-Reply-To: <1386990436-9198-4-git-send-email-dolsen@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Archives-Salt: e24e425e-0384-4fe5-bb9e-31c4cd3ab4ab X-Archives-Hash: 93738d01fdce0537a092a964bf39ecf4 On 12/13/2013 21:07, Brian Dolbec wrote: > --- > modules/generic_stage_target.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/modules/generic_stage_target.py b/modules/generic_stage_target.py > index 342c65b..1fbc733 100644 > --- a/modules/generic_stage_target.py > +++ b/modules/generic_stage_target.py > @@ -1066,9 +1066,9 @@ class generic_stage_target(generic_target): > "/use will cause portage to ignore" > print "\tpackage.use in the profile and portage_confdir. You've been warned!" > > - myf.write('PORTDIR="/usr/portage"\n') > - myf.write('DISTDIR="${PORTDIR}/distfiles"\n') > - myf.write('PKGDIR="${PORTDIR}/packages"\n') > + myf.write('PORTDIR="%s"\n' % self.settings['portdir']) > + myf.write('DISTDIR="%s"\n' % self.settings['distdir']) > + myf.write('PKGDIR="%s"\n' % self.settings['packagedir']) > > """ Setup the portage overlay """ > if "portage_overlay" in self.settings: > Do we need to still do this? Since the default location isn't hardcoded anymore, but set in repos.conf, it can be confusing if PORTDIR is set in make.conf, because it doesn't even get used. -- ♫Dustin http://dustin.hatch.name/