From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 7E917138247 for ; Sat, 14 Dec 2013 21:31:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4E90FE0ADB; Sat, 14 Dec 2013 21:31:57 +0000 (UTC) Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B042DE0ADB for ; Sat, 14 Dec 2013 21:31:56 +0000 (UTC) Received: by mail-pa0-f41.google.com with SMTP id lf10so1408487pab.0 for ; Sat, 14 Dec 2013 13:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=oIYeiIfxykjAlEg10I3mcBdVPMYc7y70WYsrNZtszBs=; b=DSCT7MP84B9aeVKEv2Stri4nu0nHKq2Q1EL5eRxxYK/ZHG6JBZ1TeyxfHKZJtxbrBI 5ttL4pu5Iiw32gJT8LA7BA5xvmbPTnKIn7IbMXjBPHUHYjCdAG9bp5ZYtUZ9IRntcAzl 6JK5Zz+ET+CmylchycmEEKQ3JVxS8+MOqVTjPk2AHZYy6D9T/PLIHCIFoyvOaK2NS+QC pVuwj6vbmitWuusc4KwKTEmjdhZtV9z+ada8DHXWYdHlWA6kh7H4kQam2Jko2AE7MSba 4JREUB87xMiV9NaV4Qy6HmOcYTsMGVvZ67/WYh6VMcnC1GDoBYbPl+9x/TVNsFVDQC83 /7hg== X-Received: by 10.66.159.234 with SMTP id xf10mr11332399pab.139.1387056715699; Sat, 14 Dec 2013 13:31:55 -0800 (PST) Received: from [172.31.0.8] (cpe-75-87-80-46.kc.res.rr.com. [75.87.80.46]) by mx.google.com with ESMTPSA id qz9sm14678065pbc.3.2013.12.14.13.31.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Dec 2013 13:31:54 -0800 (PST) Message-ID: <52ACCE46.5030204@gmail.com> Date: Sat, 14 Dec 2013 15:31:50 -0600 From: "Dustin C. Hatch" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 2/4] Remove self.mounts and self.mountmap's use of paths for keys and paths. References: <1386990436-9198-1-git-send-email-dolsen@gentoo.org> <1386990436-9198-3-git-send-email-dolsen@gentoo.org> <3834721.6I8o79ffCh@moiraine> <20131214164214.GZ25409@odin.tremily.us> In-Reply-To: <20131214164214.GZ25409@odin.tremily.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Archives-Salt: 7621fd90-89ee-4383-b41b-be8805f5e367 X-Archives-Hash: acd60032c25ca82863661dc6ed2f4727 On 12/14/2013 10:42, W. Trevor King wrote: > The current code base is so far from PEP 8 that changing touched > sections to match PEP 8 looks really out of place. In this instance > it's probably fine, but I'd ok with putting off all/most PEP 8 > cleanups to their own pure-reformatting commits. > > Cheers, > Trevor > I strongly agree with this idea. If we start mixing PEP8 and non PEP8 compliant code, it will get really hard to read really fast. I think we should wait until most if not all of this rewrite get onto master before we start changing stuff for the sake of reformatting. -- ♫Dustin http://dustin.hatch.name/