From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4862C13838B for ; Wed, 10 Sep 2014 17:15:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6AD13E07EC; Wed, 10 Sep 2014 17:15:37 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0835DE07EC for ; Wed, 10 Sep 2014 17:15:36 +0000 (UTC) Received: from [192.168.1.10] (pool-72-95-142-204.pitbpa.fios.verizon.net [72.95.142.204]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: zerochaos) by smtp.gentoo.org (Postfix) with ESMTPSA id C63D03400F1 for ; Wed, 10 Sep 2014 17:15:35 +0000 (UTC) Message-ID: <5410876F.8000505@gentoo.org> Date: Wed, 10 Sep 2014 13:16:31 -0400 From: "Rick \"Zero_Chaos\" Farina" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH v2] stage1-controller.sh: Remove some old poor cleaning code References: <1409625101-27112-4-git-send-email-dolsen@gentoo.org> <1409634345-5378-1-git-send-email-dolsen@gentoo.org> <20140909113844.6220aee6.dolsen@gentoo.org> In-Reply-To: <20140909113844.6220aee6.dolsen@gentoo.org> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jW0eEw0rEdQDTgPw9fVgUOISN1DClk67Q" X-Archives-Salt: d273a8c4-3a58-45c1-8890-1a8d402c6b6a X-Archives-Hash: 084b3fee5891dd673d974e0221fa7090 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jW0eEw0rEdQDTgPw9fVgUOISN1DClk67Q Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/09/2014 02:38 PM, Brian Dolbec wrote: > On Mon, 1 Sep 2014 22:05:45 -0700 > Brian Dolbec wrote: >=20 >> This code had portage bin path hard coded. That path needed to be >> changed for a new portage ebuild and install system. >> After testing the origianl code and comparing it with some updated >> code supplied by Douglas Freed. It turned out both code chunks >> resulted in nothing being cleaned. >> >> Tested and confirmed by zero_chaos. >=20 > I have gone over things more and tested the new find command. It does > work on my host system. However, the question remains... DOES this > particular cleaning operation NEED to be performed? >=20 > With current the tree snapshot for my testing 20140829. It does not > find anything to clean. BUT, will that remain the same in the future > as pkgs are bumped? >=20 > For safety, I'd be inclined to keep the find command (v1 of the > patch) and clean any it does find just in case. >=20 If we truly need to remove these files, I don't think catalyst was ever the place to do this. We have USE=3Dstatic and USE=3Dstatic-libs for a reason. Randomly removing files from the filesystem was a hack then, and if we are cleaning this up let's just remove it. If I want to build things with USE=3Dstatic or USE=3Dstatic-libs then catalyst shouldn't be pointlessly crippling my builds. v2 means one less horrible hack in catalyst, and one at a time is the only way will remove all the horror. -Zero --jW0eEw0rEdQDTgPw9fVgUOISN1DClk67Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUEIdyAAoJEKXdFCfdEflKWe8P/itN1/z2Zgb8B2nuKrG2zZVn GLikadxtmg42OxS6iUAJ0ccXZX9W+dWZEJ36FdgzDg/IoUcw2iYbC6QcH8cpi6B+ gcIx6hB+XrrRBQwq4+78qlprUWfnVB0obMP0E/P4ZkPAqek6wCuqJzDuN1zLJJj7 yyEuv4sH7FVOFJd2v4HYP+rdHdflUCzeoovWgJt8P6mHIeI8sOBYZus1gi3rspmK VdfcnvFBtF2MabNeg1MCYZKRPwV/temIjgZzlcp5KMB7abQB4Z4vkuV43n9Yqiub s1c3FNIgE55nIfs1GeMIwIfT/YW9JtNrMjU4DWxUeAgin3BjoJ8/B9x3n2EUIa+j lLMF6QiiBOWs6joTCBep/Ew4wQ6XIsOLxCf9eTYOtV8PU8/FLlRdeikEYqFGuKPc MRGy1A7vpYTB8RLxMIXgKKFt4KxiRdUfQEwEjRA51bdbuF6JSjnGIS84z/DAOVlb pOowd83xWkSzRiicOYbEkddEqErSl0BhgUfgmzlTfXQ1jhI8rXGfDdmE82gCDzUH 826SDQRIjGuYiSMzsxJ6CFBGADr5Rc6PreGRWPnkN5NJSeLCt5A6A7d7KXaqvDtJ v/TQr3WVeRYXzOQX+LHjrTBveoWcmTgpyGU04CHcM5vAECbjLfwqTtn28BBEHdeX kkqBTj6DO9N2ycryJyUT =I27w -----END PGP SIGNATURE----- --jW0eEw0rEdQDTgPw9fVgUOISN1DClk67Q--