From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 22FFC13888F for ; Tue, 6 Oct 2015 11:09:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EA9C921C006; Tue, 6 Oct 2015 11:09:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4529F21C006 for ; Tue, 6 Oct 2015 11:09:26 +0000 (UTC) Received: from greysprite.dite (cpe-74-77-145-97.buffalo.res.rr.com [74.77.145.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: blueness) by smtp.gentoo.org (Postfix) with ESMTPSA id 26BB1340894 for ; Tue, 6 Oct 2015 11:09:25 +0000 (UTC) Subject: Re: [gentoo-catalyst] [PATCH] lock: fix hardlink_active definition To: gentoo-catalyst@lists.gentoo.org References: <1444103287-14519-1-git-send-email-vapier@gentoo.org> <20151005234156.0d2c07bf.dolsen@gentoo.org> From: "Anthony G. Basile" Message-ID: <5613ABE0.4060200@gentoo.org> Date: Tue, 6 Oct 2015 07:09:20 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20151005234156.0d2c07bf.dolsen@gentoo.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: 922b805f-2a3d-4e28-946c-e7a136eee067 X-Archives-Hash: 6b520d941750f278e89dc1f0818dc5ed On 10/6/15 2:41 AM, Brian Dolbec wrote: > On Mon, 5 Oct 2015 23:48:07 -0400 > Mike Frysinger wrote: > >> This is a member function of a class, so it must have a |self| >> argument first. The current code is clearly broken otherwise. Not >> that it seems to matter as there aren't any callers in the current >> codebase. --- >> catalyst/lock.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/catalyst/lock.py b/catalyst/lock.py >> index a6f9d3a..9f954eb 100644 >> --- a/catalyst/lock.py >> +++ b/catalyst/lock.py >> @@ -354,7 +354,7 @@ class LockDir: >> return True >> return False >> >> - def hardlink_active(lock): >> + def hardlink_active(self, lock): >> if not os.path.exists(lock): >> return False >> > > :) > > If you want to re-do all the lock code, go for it. I know Anthony was > looking at putting that on to his TODO list. Maybe the two of you can > get it all in great shape. > we should write a separate class for file locking with a timeout. the motivation here is bug #519656. I wrote a sketch of what the class would do, but I have been more involve with working on GRS and just haven't gotten to it. also on the TODO list is to get catalyst using cgroup. catalyst just doesn't die well on TERM or INT. with GRS I use cgroups and its amazingly clean. one of the best features added to the kernel in recent history. -- Anthony G. Basile, Ph.D. Gentoo Linux Developer [Hardened] E-Mail : blueness@gentoo.org GnuPG FP : 1FED FAD9 D82C 52A5 3BAB DC79 9384 FA6E F52D 4BBA GnuPG ID : F52D4BBA