From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B5C2213888F for ; Sat, 10 Oct 2015 09:13:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D04D7E07E1; Sat, 10 Oct 2015 09:13:44 +0000 (UTC) Received: from virtual.dyc.edu (mail.virtual.dyc.edu [67.222.116.22]) by pigeon.gentoo.org (Postfix) with ESMTP id 6C129E07E1 for ; Sat, 10 Oct 2015 09:13:44 +0000 (UTC) Received: from greysprite.dite (cpe-74-77-145-97.buffalo.res.rr.com [74.77.145.97]) by virtual.dyc.edu (Postfix) with ESMTPSA id 9637F7E00D0 for ; Sat, 10 Oct 2015 05:13:43 -0400 (EDT) Subject: Re: [gentoo-catalyst] [PATCH] targets: do not prompt user To: gentoo-catalyst@lists.gentoo.org References: <1444453873-1156-1-git-send-email-vapier@gentoo.org> From: "Anthony G. Basile" Message-ID: <5618D6C6.4070903@opensource.dyc.edu> Date: Sat, 10 Oct 2015 05:13:42 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <1444453873-1156-1-git-send-email-vapier@gentoo.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: 48085e03-7a1f-4c1e-a33b-5e294971c457 X-Archives-Hash: f89b2d4d370894cd708e11c355923d3c On 10/10/15 1:11 AM, Mike Frysinger wrote: > Catalyst shouldn't delay & read from stdin and prompt the user. > Currently, using verbose mode will trigger that behavior. > --- > targets/stage2/stage2-chroot.sh | 7 ------- > targets/support/chroot-functions.sh | 7 ------- > targets/tinderbox/tinderbox-chroot.sh | 7 ------- > 3 files changed, 21 deletions(-) > > diff --git a/targets/stage2/stage2-chroot.sh b/targets/stage2/stage2-chroot.sh > index 0e21ea6..b426dab 100755 > --- a/targets/stage2/stage2-chroot.sh > +++ b/targets/stage2/stage2-chroot.sh > @@ -8,13 +8,6 @@ export FEATURES="${clst_myfeatures} nodoc noman noinfo -news" > if [ "${clst_VERBOSE}" ] > then > /usr/portage/scripts/bootstrap.sh -p ${bootstrap_opts} > - echo "Press any key within 15 seconds to pause the build..." > - read -s -t 15 -n 1 > - if [ $? -eq 0 ] > - then > - echo "Press any key to continue..." > - read -s -n 1 > - fi > fi > > # Set bindist USE flag if clst_BINDIST is set > diff --git a/targets/support/chroot-functions.sh b/targets/support/chroot-functions.sh > index 2482651..fe40157 100755 > --- a/targets/support/chroot-functions.sh > +++ b/targets/support/chroot-functions.sh > @@ -288,13 +288,6 @@ run_merge() { > then > echo "ROOT=${ROOT} emerge ${clst_myemergeopts} -pt $@" || exit 1 > emerge ${clst_myemergeopts} -pt $@ || exit 3 > - echo "Press any key within 15 seconds to pause the build..." > - read -s -t 15 -n 1 > - if [ $? -eq 0 ] > - then > - echo "Press any key to continue..." > - read -s -n 1 > - fi > fi > > echo "emerge ${clst_myemergeopts} $@" || exit 1 > diff --git a/targets/tinderbox/tinderbox-chroot.sh b/targets/tinderbox/tinderbox-chroot.sh > index 4ebc2cc..74e46d6 100755 > --- a/targets/tinderbox/tinderbox-chroot.sh > +++ b/targets/tinderbox/tinderbox-chroot.sh > @@ -15,13 +15,6 @@ do > if [ -n "${clst_VERBOSE}" ] > then > run_merge --usepkg --buildpkg --newuse -vp $x > - echo "Press any key within 15 seconds to pause the build..." > - read -s -t 15 -n 1 > - if [ $? -eq 0 ] > - then > - echo "Press any key to continue..." > - read -s -n 1 > - fi > fi > > mkdir -p /tmp/packages/$x > I haven't followed all of your commits closely, but I assume you're moving towards properly daemonizing catalyst, ie. close stdin/stdout/stderr and redirecting to logs? -- Anthony G. Basile, Ph. D. Chair of Information Technology D'Youville College Buffalo, NY 14201 (716) 829-8197