From: "Anthony G. Basile" <blueness@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 1/2] stagebase: simplify lock calls a bit
Date: Sun, 11 Oct 2015 10:14:41 -0400 [thread overview]
Message-ID: <561A6ED1.7050208@gentoo.org> (raw)
In-Reply-To: <1444528479-3858-1-git-send-email-vapier@gentoo.org>
On 10/10/15 9:54 PM, Mike Frysinger wrote:
> We create self.snapcache_lock to hold the lock, then assign it to
> self.snapshot_lock_object, and then operate on self.snapshot_lock_object.
> There's no need for this indirection, so operate on self.snapcache_lock
> directly instead.
> ---
> catalyst/base/stagebase.py | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
This and the next patch look fine and simplify matters a lot. This
doesn't fix bug #519656 but it clears the way. When running multiple
instances of catalyst, if the second instance tries to acquire the lock
on the snapcache while the first one has it, it throws and exception
instead of waiting on the lock. It would be nice for it to wait and
timeout if it doesn't get the lock within some acceptable time limit.
On systems with lots-o-cores I run mutliple instances of catalyst to
economize on throughput.
--
Anthony G. Basile, Ph.D.
Gentoo Linux Developer [Hardened]
E-Mail : blueness@gentoo.org
GnuPG FP : 1FED FAD9 D82C 52A5 3BAB DC79 9384 FA6E F52D 4BBA
GnuPG ID : F52D4BBA
prev parent reply other threads:[~2015-10-11 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 1:54 [gentoo-catalyst] [PATCH 1/2] stagebase: simplify lock calls a bit Mike Frysinger
2015-10-11 1:54 ` [gentoo-catalyst] [PATCH 2/2] lock: gut & replace with snakeoil Mike Frysinger
2015-10-11 14:14 ` Anthony G. Basile [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561A6ED1.7050208@gentoo.org \
--to=blueness@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox