From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8B3881381F3 for ; Sun, 13 Oct 2013 09:19:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A78F0E09AD; Sun, 13 Oct 2013 09:19:09 +0000 (UTC) Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1330FE09AD for ; Sun, 13 Oct 2013 09:19:08 +0000 (UTC) Received: by mail-pa0-f43.google.com with SMTP id hz1so6278076pad.16 for ; Sun, 13 Oct 2013 02:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-type; bh=3Gi0TNqOe3k5nyGLGBDwUSEcvvOUAjJwcEHdO/kSJBQ=; b=ImCTzkcRHdf4bxkBlXihzKnASlNPSuHA/w2FcdnwNgFsowsuH4PYYCpePqan2GQ1Rh WVanwDi+vbPmGf5Uj/asAGKLEslpShuoT4LbhBk4ZkZ6W6a+GAYQDD/BFcli1l4DQ7oD KZpvtfvER586AwXiNPn8eFNvxEUw/0b7rmtAe3oqdNBh33EyGrAKOD70I9GJn2oJOP48 itPtpHgfSaCpdoIOFh0MW7Jknf6oe22yu/xi2fdVcmhwiIRmtVdGRPsK4kIujCdt3v5C CRml4e48MAl9vILXh0lYCClnGMrIomu+SQAbcdfoRaWTRKsJKwYAzP7QGzBVm3sMppLy oMYA== X-Received: by 10.66.226.46 with SMTP id rp14mr1739879pac.133.1381655947902; Sun, 13 Oct 2013 02:19:07 -0700 (PDT) Received: from moiraine.localnet ([50.126.105.238]) by mx.google.com with ESMTPSA id uw6sm70929013pbc.8.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 13 Oct 2013 02:19:07 -0700 (PDT) From: Dylan Baker To: gentoo-catalyst@lists.gentoo.org Cc: Matt Turner Subject: Re: [gentoo-catalyst] [PATCH 1/4] catalyst: Specify python2 rather than the generic python Date: Sun, 13 Oct 2013 02:19:07 -0700 Message-ID: <57571850.3NIjWDLY5n@moiraine> User-Agent: KMail/4.11.2 (Linux/3.11.0; KDE/4.11.2; x86_64; ; ) In-Reply-To: References: <1381513107-17483-1-git-send-email-baker.dylan.c@gmail.com> <1381525900.24205.87.camel@big_daddy.dol-sen.ca> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3518516.LKOvfWg6zB"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-Archives-Salt: ebb9dea5-c8d8-49b0-b727-0fa9897b7a13 X-Archives-Hash: 1eb02062333e1c3505f809d2ea9c03dd --nextPart3518516.LKOvfWg6zB Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, October 11, 2013 02:58:22 PM Matt Turner wrote: > On Fri, Oct 11, 2013 at 2:11 PM, Brian Dolbec wrote: > > On Fri, 2013-10-11 at 12:28 -0700, Matt Turner wrote: > >> On Fri, Oct 11, 2013 at 11:15 AM, Brian Dolbec wrote: > >> > This is only > >> > good for running the code directly from the git checkout. > >> > >> actually seems useful. We've had clearly broken commits go upstream, > >> and if the author had been able to test from a git checkout we > >> probably could have avoided that. > > > > Which is why I made the rewrite code able to run from the checkout fully > > and properly. Just cd into the directory, run "source ./testpath" and > > it's will run completely from the checkout. > > > >> What I mean is that I don't want to turn down contributions from new > >> developers because there's a big backlog of work that hasn't gone > >> upstream. > > > > I don't want to discourage others either. It is just much better to > > encourage some help on the rewrite in my opinion. > > No, you should be moving patches that are reviewed and tested to > master (which means rebasing on master and sending patches to the > mailing list). > > > Especially since > > patches 2 & 3 have already been done in the rewrite branch. Some of > > patch 4 might have been done already, but likely not all. If the > > rewrite is to take over from the master branch... > > > > The rewrite is not far from being able to take over as master. There > > are a few rebase errors in the rewrite-on-master you did. There is some > > cleanup work to do on the autoresume operation. Then a little more > > testing with the tree defaults relocated to ensure I haven't missed any > > hard coding. > > The development model on git is to make incremental changes that do > not break things. I've been saying this for a while. > > The code needs to be reviewed as well. Maybe Dylan, who has been > cleaning up a lot of python code in another project, would be willing > to help review as well. I'd be more than happy to help review things. I've paged through the rewrite- on-master branch a bit, and there's definately some good work going on there, but there are also so things that could be polished up a bit. > > > The default tree location move is waiting on the catalyst rewrite code > > to go live producing stages, etc.. > > I'm exactly sure what this means, but I think you might mean something > like renaming master to old-master and your branch to master. That's > not the right way to do it, and that's not how git works. --nextPart3518516.LKOvfWg6zB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQEcBAABAgAGBQJSWmWLAAoJEAieFpYUBojv/CwH/jngeadzEYxMRqUeqMPsmdyl iVWuaw8U7pwYYmnP/lVCBChgYMbxm6emcp+Wy5pxAPnXRISMJeyOfS/YTCbAFsmy KmwPLkb0OLXvRxNMhYOgQyHf2gvcL0iJ+AlD3Q3Z+KAnLazz6+q6GvI878psXkLT VVbiG6MRmVJIvHPFj5rCe5kQ1FhIJgMWxa39tNaHXT+/uQwrrLlltjZQ5riAeqsS 0WdIS9GM8R1g6x6tSEgruVaockR1VOv7TZFxE2r+cS6Kvz3IhrM7U4gq3hhwUJ4i 1bIExfrHv/+gI8B1mcMDVDoNeYa9tSde0UX/V+AKUSs1OLS++AGiqFebnqjdrmg= =/cea -----END PGP SIGNATURE----- --nextPart3518516.LKOvfWg6zB--