From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id EBA9E13827E for ; Sat, 14 Dec 2013 15:03:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6625CE0B06; Sat, 14 Dec 2013 15:03:50 +0000 (UTC) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D10A3E0B06 for ; Sat, 14 Dec 2013 15:03:49 +0000 (UTC) Received: by mail-pa0-f42.google.com with SMTP id lj1so1209977pab.1 for ; Sat, 14 Dec 2013 07:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-type; bh=QiqXxWg3KaGeGsMu8MVodWEeLiyuwR60Lxt/fvAW8lw=; b=Yz1p85/MSlEfJFmbejkAv3+ewuya1jKGj31gJR1AMTSUJkqa70qVtzNhYWMN8SAv32 EDfexx6zesWpJkAa4oOLPcLRdIZ+myf0HP/5XQV7bc/ai4LSTwot3ybV8xSP9g0Clmte VfDDM38T3k3N/RI7GLCmmaJi++l39idsVV43FvvcVGlano5Knz1yqxxofCDE6gnFkpBe IQM9QCo3KUhZXEIgf+Ru1tM1SgfDXHS97Q24YqAoln8eKlGV5kMbZXZSHzo5xA/8wg9T LD/kNkfIy7rYLYjTKVqh38xbSmY/R43o/oXLu0prXrYx2rHfi6vHEwRPgmFhO/Mj1IYQ 68Zw== X-Received: by 10.68.232.196 with SMTP id tq4mr809294pbc.166.1387033428692; Sat, 14 Dec 2013 07:03:48 -0800 (PST) Received: from moiraine.localnet ([50.126.105.238]) by mx.google.com with ESMTPSA id pa1sm17308873pac.17.2013.12.14.07.03.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2013 07:03:47 -0800 (PST) From: Dylan Baker To: gentoo-catalyst@lists.gentoo.org Cc: Brian Dolbec Subject: Re: [gentoo-catalyst] [PATCH 3/4] Adapt commit c52962b6bd2 to use the new configured settings values. Date: Sat, 14 Dec 2013 06:54:03 -0800 Message-ID: <693519560.0lWei86J99@moiraine> User-Agent: KMail/4.11.4 (Linux/3.12.5; KDE/4.11.4; x86_64; ; ) In-Reply-To: <1386990436-9198-4-git-send-email-dolsen@gentoo.org> References: <1386990436-9198-1-git-send-email-dolsen@gentoo.org> <1386990436-9198-4-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1575738.KRlmoehEKc"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-Archives-Salt: 17e0b046-da4e-4c53-9900-1f17ee3f6d16 X-Archives-Hash: 6775d67172faeff6b44a2c16e78ea8c5 --nextPart1575738.KRlmoehEKc Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, December 13, 2013 07:07:15 PM Brian Dolbec wrote: > --- > modules/generic_stage_target.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/modules/generic_stage_target.py > b/modules/generic_stage_target.py index 342c65b..1fbc733 100644 > --- a/modules/generic_stage_target.py > +++ b/modules/generic_stage_target.py > @@ -1066,9 +1066,9 @@ class generic_stage_target(generic_target): > "/use will cause portage to ignore" > print "\tpackage.use in the profile and portage_confdir. You've been > warned!" > > - myf.write('PORTDIR="/usr/portage"\n') > - myf.write('DISTDIR="${PORTDIR}/distfiles"\n') > - myf.write('PKGDIR="${PORTDIR}/packages"\n') > + myf.write('PORTDIR="%s"\n' % self.settings['portdir']) > + myf.write('DISTDIR="%s"\n' % self.settings['distdir']) > + myf.write('PKGDIR="%s"\n' % self.settings['packagedir']) what is the point of this? These produce exactly the same output, except the previous is more readable. > > """ Setup the portage overlay """ > if "portage_overlay" in self.settings: --nextPart1575738.KRlmoehEKc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAABAgAGBQJSrHELAAoJEAieFpYUBojvWBwH/R0kdZ0X1v0kQsublE024kOB Q2iDmcgO6R76Au/E7DE2hgluLptEq6tHpg2uxLX++egyYJEdapja2etYNRvylOMJ z67s/OkK/q0UYqdskwhYnAgr4/9fNYYxcL1H/vT6IKB9YvOZ0qgJUVlyiemKkZi5 jHDyVmFfNbERugQrfiUwEfLApywg5zJxZrLDb25ENrHRf/fm1D+5ozBbfCjDf0oW EBgKY4yOc1mwdScu//rTLA3BIdatcGoZhMarsM4ofyGZdE8ChVxaWS5o8ft99hmo xZaO+qfulROWAVSdqmMqXHzMwBKIgPX+CUhBZIJquDBSU/a+fhhfvPzWPXIeUic= =oOp8 -----END PGP SIGNATURE----- --nextPart1575738.KRlmoehEKc--