From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [rfc] Compile flag derivation logic (catalyst 2.x)
Date: Sat, 25 Jun 2011 22:33:00 -0400 [thread overview]
Message-ID: <BANLkTikJmOjQgSQWDQjoWf1i1DeO0B8vyw@mail.gmail.com> (raw)
In-Reply-To: <4E0693B6.1010304@gentoo.org>
On Sat, Jun 25, 2011 at 10:04 PM, Sebastian Pipping <sping@gentoo.org> wrote:
> Hello!
>
>
> It seems that in order to get your own compile flags applied for a
> stage3 or stage4 build you need to append a "CFLAGS=" line to
> /etc/make.conf from within the envscript - quite a dirty workaround not
> to mention the fact that the envscript is sourced multiple times.
>
> This is how final CFLAGS seem to be derived (numbers indicate order so
> higher numbers win):
>
> Targets "stage1, "stage2"
> 1) key "CFLAGS" subarch defaults
> 2) key "CFLAGS" earlier /etc/make.conf
> 3) key "cflags" conf file
> 4) key "cflags" spec file
>
> Targets "stage3", "stage4", "generic_stage"
> 1) key "CFLAGS" subarch defaults
> 2) key "CFLAGS" earlier /etc/make.conf
>
> That explains why my stage4 "subarch: core2" isn't really changing
> anything: it gets overriden by the /etc/make.conf from the stage3 I am
> using.
>
> Is that what you are expecting?
>
> Is my picture broken - are you experiencing something else with your
> stage builds?
>
> Can you thing of reasons to not allow overriding CFLAGS and friends for
> stage3 and stage4 builds?
Thanks for writing this up. This has always been a maze to me, so this
is very useful.
I can't think of a situation where CFLAGS specified in the spec or
conf file should be overridden by the CFLAGS in /etc/make.conf. So,
this seems wrong.
Are you saying that cflags specified in the spec file are totally
ignored for stage3 and stage4? That seems totally broken.
Matt
next prev parent reply other threads:[~2011-06-26 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 2:04 [gentoo-catalyst] [rfc] Compile flag derivation logic (catalyst 2.x) Sebastian Pipping
2011-06-26 2:33 ` Matt Turner [this message]
2011-06-26 2:43 ` Sebastian Pipping
2011-06-26 23:00 ` Peter Stuge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikJmOjQgSQWDQjoWf1i1DeO0B8vyw@mail.gmail.com \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox