From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5807F138239 for ; Sun, 21 Feb 2021 01:59:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8BDCEE0863; Sun, 21 Feb 2021 01:59:05 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 61685E0863 for ; Sun, 21 Feb 2021 01:59:05 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id bl23so23186837ejb.5 for ; Sat, 20 Feb 2021 17:59:04 -0800 (PST) X-Gm-Message-State: AOAM5309naiDpfdtXepx0rlczBDX79EDrXNYUxJErXjoY9Tzu/8yGRfR VO9HNhtLwp+I3TZp1Jl03n9FT/X4QL1fc38fIoU= X-Google-Smtp-Source: ABdhPJyEIowOUdFnPtkGm3B0kuWokMQBnQCWsPIWtWG34VIVJrVCKAIBryhGtQRSjiE4w4ro3AcdaGz0KyvOxiHUp/Q= X-Received: by 2002:a17:906:4acf:: with SMTP id u15mr12667358ejt.497.1613872741352; Sat, 20 Feb 2021 17:59:01 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: In-Reply-To: From: Matt Turner Date: Sat, 20 Feb 2021 20:58:49 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 5/5] Drop PORTDIR from make.conf To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: a85af9c8-75ee-4f2d-939e-2a656ceebf4e X-Archives-Hash: 981957184dae1c1fab874e451dd437c8 'On Wed, Feb 3, 2021 at 7:45 PM Felix Bier wrote: > > This commit drops PORTDIR from being included in the generated > make.conf. The variable is no longer needed, since the existing code > will now generate a repos.conf entry for the main repo when needed > (i.e. when the location is non-default, which is the same condition > that was applied for PORTDIR in the code removed by this commit). > > The PORTDIR variable is considered deprecated in favor of > repos.conf entries (reference: https://wiki.gentoo.org/wiki/PORTDIR). Thank you! The patches look great. I've committed them. > Signed-off-by: Felix Bier > --- > These patches are intended for application top of 50ba8aad (current master). > To test for formatting issues, I sent the patches to myself, exported the mails > as mbox files and applied them with git am *mbox. I appreciate that! For whatever reason I still had some trouble applying them. I ran dos2unix, deleted the 'Content-Transfer-Encoding: base64' header and ran base64 -d on the body and they applied cleanly. Strange.