From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C2E41138350 for ; Sat, 2 May 2020 23:19:10 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 11623E08A2; Sat, 2 May 2020 23:19:10 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D3129E08A2 for ; Sat, 2 May 2020 23:19:09 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id a2so10648032ejx.5 for ; Sat, 02 May 2020 16:19:09 -0700 (PDT) X-Gm-Message-State: AGi0Pub5rtQzJNe6wMwP1iBgA+1SxSA38k+LyNL46+cjtC6WUTE7MW23 bgKcsr4UchmcT+hARCd8I7EMBw3qCsNfsx1nHoo= X-Google-Smtp-Source: APiQypL+DxoqJCl6rEe79cXCmY9hHv0qFTardkS9y3UO/NUggfClTA8SzxP16NTLL3RFaDZ/ubnlUXbJpPS8X7K7a+U= X-Received: by 2002:a17:906:af67:: with SMTP id os7mr8939210ejb.182.1588461534886; Sat, 02 May 2020 16:18:54 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20200502014036.1039317-1-mattst88@gentoo.org> <20200502014036.1039317-3-mattst88@gentoo.org> <20200502160342.3d3b05ca@storm> In-Reply-To: <20200502160342.3d3b05ca@storm> From: Matt Turner Date: Sat, 2 May 2020 16:18:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 3/8] targets: Inline filesystem-functions.sh To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: ae218acf-7345-401c-9adb-c09d2e7c3600 X-Archives-Hash: bb1a48a48e1ae2672f34a27fd154e695 On Sat, May 2, 2020 at 4:03 PM Brian Dolbec wrote: > > On Fri, 1 May 2020 18:40:31 -0700 > Matt Turner wrote: > > > Signed-off-by: Matt Turner > > --- > > Again, no reasoning Sorry. I think it's pretty apparent. Simple functions that are called only from a single place and exist in a different file should just be inlined. Should I just add that to the commit message?