public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Cc: Brian Dolbec <dolsen@gentoo.org>
Subject: Re: [gentoo-catalyst] [PATCH 1/4] Whitespace cleanup.
Date: Thu, 28 Feb 2013 15:44:17 -0800	[thread overview]
Message-ID: <CAEdQ38ERFjc6UqAVQdNG4q5LhQQeqUjZqb7EXLhQfX5brzkyVw@mail.gmail.com> (raw)
In-Reply-To: <20130228114625.GA2625@odin.tremily.us>

On Thu, Feb 28, 2013 at 3:46 AM, W. Trevor King <wking@tremily.us> wrote:
> On Wed, Feb 27, 2013 at 05:46:58PM -0800, Brian Dolbec wrote:
>> Run the following command to cleanup whitespace.
>>   for FILE in $(git ls-tree -r --name-only HEAD | grep -v 'bz2$'); do
>>     sed -i 's/[[:space:]]*$//' "$FILE"
>>   done
>
> Since you dropped the changes to COPYING, you should probably add
> COPYING to the grep (grep -v 'bz2$\|COPYING') or add `git checkout
> COPYING` after the for loop.
>
>> Signed-off-by: Brian Dolbec <dolsen@gentoo.org>
>
> I don't thing this is appropriate for catalyst, since we never
> document its meaning for this project.  If we *do* want to add
> Linux/Git-style sign-offs, I've got the docs all pulled out into their
> own GPLv2 project [1], which could be merged into catalyst.  In this
> case, I imagine it's not worth the trouble ;).

Yeah, I don't think S-o-B adds anything. I've stopped using them for
everything but the X server and kernel.


  reply	other threads:[~2013-02-28 23:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28  1:46 [gentoo-catalyst] [PATCH 0/4] Some general cleanup, remove some hardcoding of paths Brian Dolbec
2013-02-28  1:46 ` [gentoo-catalyst] [PATCH 1/4] Whitespace cleanup Brian Dolbec
2013-02-28 11:46   ` W. Trevor King
2013-02-28 23:44     ` Matt Turner [this message]
2013-03-09  2:36   ` Matt Turner
2013-02-28  1:46 ` [gentoo-catalyst] [PATCH 2/4] Add more configured defaults Brian Dolbec
2013-02-28 11:51   ` W. Trevor King
2013-02-28  1:47 ` [gentoo-catalyst] [PATCH 3/4] Remove self.mounts and self.mountmap's use of paths for keys and paths Brian Dolbec
2013-02-28  3:01   ` Brian Dolbec
2013-02-28  1:47 ` [gentoo-catalyst] [PATCH 4/4] cleanup long lines, improve useage() output formatting slightly Brian Dolbec
2013-02-28 13:17 ` [gentoo-catalyst] [PATCH 0/4] Some general cleanup, remove some hardcoding of paths W. Trevor King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEdQ38ERFjc6UqAVQdNG4q5LhQQeqUjZqb7EXLhQfX5brzkyVw@mail.gmail.com \
    --to=mattst88@gentoo.org \
    --cc=dolsen@gentoo.org \
    --cc=gentoo-catalyst@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox