From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 59D54138359 for ; Sat, 17 Oct 2020 20:12:07 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 503B6E0932; Sat, 17 Oct 2020 20:12:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 35EFEE0932 for ; Sat, 17 Oct 2020 20:12:04 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id x7so8336431eje.8 for ; Sat, 17 Oct 2020 13:12:03 -0700 (PDT) X-Gm-Message-State: AOAM531eZMtwuq54C5faIKYMN9/BeODMa3R9J4CI7+f7Gkr3+a8Ywg0+ kH1jJa2twQCecK5OmxpTUITQq79ALl0Q3paZDwU= X-Google-Smtp-Source: ABdhPJyex17fYnlVWvOTkuW/0f5xaSPSBby/GRw4FUkB+Kx2X3/xUchO0tdqqbyQ8vokuJknKtHm16YdWtI78W4dmZM= X-Received: by 2002:a17:906:4a97:: with SMTP id x23mr9770410eju.471.1602965520069; Sat, 17 Oct 2020 13:12:00 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <914cce4739709511771f27bed773c7e4e01c3c9a.camel@rohde-schwarz.com> In-Reply-To: <914cce4739709511771f27bed773c7e4e01c3c9a.camel@rohde-schwarz.com> From: Matt Turner Date: Sat, 17 Oct 2020 13:11:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 2/2] Move from PORTDIR_OVERLAY to repos.conf To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: 61e89d9a-eb76-4f89-a01b-6d5302e79bc0 X-Archives-Hash: 9780fde847e4d227a274efd35bc3132b On Sat, Oct 17, 2020 at 12:00 PM Felix Bier wrote: > > This commit fixes the following issues: > > * The PORTDIR_OVERLAY variable has been deprecated by Gentoo. > > With this commit, the variable is no longer written to the > generated make.conf. Instead, a config file > /etc/portage/repos.conf/.conf > is generated for each overlay. The repo name is read from the > overlay using the portage API. Internally, portage parses > metadata/layout.conf and profiles/repo_name to obtain the name. > > References: > https://wiki.gentoo.org/wiki//etc/portage/make.conf > https://wiki.gentoo.org/wiki//etc/portage/repos.conf > > * All overlays were copied into the same target directory. If the > same file name occurred in multiple overlays, the last overlay > would overwrite all previous files with this name. In particular, > only the metadata/layout.conf of the last overlay was retained, > so it was not possible to reference the other overlays e.g. via > the masters entry in the layout.conf or the portage-2 syntax > for specifying a parent profile from another overlay. Also, > this created problems when the overlays contained ebuilds > for the same package, but with differing versions, because > after copying, the target directory contained both versions of the > ebuild but only the manifest file of the last overlay. > > With this commit, each overlay is copied into a separate > sub-directory, e.g. /var/gentoo/repos/local//. > This directory is referenced via the location entry in the > generated /etc/portage/repos.conf/.conf. > --- Hello, Thank you for the patches. I'm happy to see them. I cannot apply the patches however. This one in particular is badly line wrapped by your mail client. I tried fixing it up, but either failed or don't know what this is supposed to apply to. It looks like the intention is for this to apply to the catalyst-3.0-stable branch since it discusses copying overlays into a subdirectory, rather than any mention of squashfs snapshots. I really don't want new feature work on the catalyst-3.0-stable branch, for example. If that is the target, then please consider rebasing the work onto the master branch. Matt