From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id EB68D1382C5 for ; Fri, 22 Jan 2021 00:05:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F2F09E0898; Fri, 22 Jan 2021 00:05:07 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7360BE0898 for ; Fri, 22 Jan 2021 00:05:07 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id g3so5164689ejb.6 for ; Thu, 21 Jan 2021 16:05:06 -0800 (PST) X-Gm-Message-State: AOAM533E09xD0sQdsjgVW3o8NQ0hiYAJV1Oeq/XjgKuKMAb8HDpKYT+6 3Z/Nq5UX7ynsxUQW/oYczU7ZYAFnKn5iCQz1zK0= X-Google-Smtp-Source: ABdhPJziQfK+4RBN0II+O3df6qtkkOG7kS46OsL/I0XMs/r8AF2sN/dAds4xcDP9RqsZPkR3BEedca2Vz4iIzgt804c= X-Received: by 2002:a17:906:154d:: with SMTP id c13mr1263540ejd.471.1611273903439; Thu, 21 Jan 2021 16:05:03 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20210118202152.374078-1-mattst88@gentoo.org> <20210118202152.374078-11-mattst88@gentoo.org> In-Reply-To: From: Matt Turner Date: Thu, 21 Jan 2021 19:04:51 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 11/11] catalyst: Remove update_seed spec option To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: 54cd8942-3368-4c4c-8bc8-a154bd12e95e X-Archives-Hash: 9a5107108ec3338eb52356c8748b6ba1 On Thu, Jan 21, 2021 at 5:20 AM Daniel Cordero wrote: > > On Tue, Jan 19, 2021 at 09:58:15AM -0500, Matt Turner wrote: > > On Tue, Jan 19, 2021 at 6:04 AM Daniel Cordero wrote: > > > On Mon, Jan 18, 2021 at 03:21:52PM -0500, Matt Turner wrote: > > > > There should be no need for custom updates, and if there are exceptional > > > > circumstances the new --enter-chroot option can be used. > > > > > > > > > > There is still a need, and if I'm reading these patches right, > > > --enter-chroot would not satisfy that need. > > > > > > enter-chroot is interactive, and, depending on hardware speed, the time > > > between kicking off the catalyst run and when the chroot shell is > > > invoked may be some time for a human operator to monitor. > > > > > > It also adds non-deterministic, un-reproducible behaviour to a build. > > > Having it in the spec file at least means it is included in a build > > > artifact. > > > > Can you think of a case where update_seed would be needed? I tried, > > and couldn't think of anything, but I might not be imaginative enough. > > > > My thinking is that with @changed-subslots, there's essentially no > > need to update the seed stage further. But there have been some > > exceptional cases that don't really fit update_seed (e.g., things that > > cannot be fixed with emerge ...). > > update_seed has been very useful when dealing with perl/python version > upgrades, where large swathes of packages need to be updated at the same > time. I'm not sure if @changed-subslots has in any way resolved this, > but it's convenient to have an override. Okay, thanks. I'll do some testing in these areas. > Another example was a recent bash/readline update, where the stage3 had > readline.so.5 and built the new stage1 bash against that, but installed > readline.so.6 into the stage1root, hence the stage2 build was broken. This is *exactly* the situation @changed-subslots is for. Please read the commit message in 05/11.