From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 32B4D138359 for ; Wed, 21 Oct 2020 03:31:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 00D1FE0AB9; Wed, 21 Oct 2020 03:31:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8E611E0AB9 for ; Wed, 21 Oct 2020 03:31:18 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id o18so957065edq.4 for ; Tue, 20 Oct 2020 20:31:17 -0700 (PDT) X-Gm-Message-State: AOAM530/64DkrIB6iQW3yJIe3Z8k8wmvWharRH4SZVbssBlL7OWxwlWr 1g28oAvCLuymfqgALWIhoc5MF7OWEwi+tIN+gZ4= X-Google-Smtp-Source: ABdhPJxtyCCc2FsejjG5tVrnuZUD8WCV9sqiqk0jOQfuIkF2Eyxtajz7p0subM7aDPrUhfI84RP1QM/I2hrYsOSp3w8= X-Received: by 2002:a50:fa89:: with SMTP id w9mr975688edr.235.1603251073893; Tue, 20 Oct 2020 20:31:13 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20201021002344.378131-1-mattst88@gentoo.org> <20201021002344.378131-2-mattst88@gentoo.org> <20201020220229.205aa9b1@rogue1> In-Reply-To: <20201020220229.205aa9b1@rogue1> From: Matt Turner Date: Tue, 20 Oct 2020 20:31:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 02/37] catalyst: Drop outdated comment To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 3d634c7a-8346-433f-bfe6-592be750a525 X-Archives-Hash: 067763e9321ad687f6ce06c47188d545 On Tue, Oct 20, 2020 at 8:02 PM Brian Dolbec wrote: > > On Tue, 20 Oct 2020 17:23:09 -0700 > Matt Turner wrote: > > > We don't use os.system anymore. We pass self.env to Popen, so the > > comment isn't accurate. > > > > Signed-off-by: Matt Turner > > --- > > catalyst/base/stagebase.py | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py > > index 48157837..532f7133 100644 > > --- a/catalyst/base/stagebase.py > > +++ b/catalyst/base/stagebase.py > > @@ -1307,11 +1307,6 @@ class StageBase(TargetBase, ClearBase, > > GenBase): print_traceback=3DFalse) > > > > def setup_environment(self): > > - """ > > - Modify the current environment. This is an ugly hack that > > should be > > - fixed. We need this to use the os.system() call since we > > can't > > - specify our own environ > > - """ > > log.debug('setup_environment(); settings =3D %r', > > self.settings) for x in list(self.settings): > > log.debug('setup_environment(); processing: %s', x) > > > Instead of deleting the entire docstring, change it to reflect the > correct info. =E2=80=8Cpylint will bitch about the lack of a docstring. We're missing docstrings almost everywhere and have the pylint warning disabled. From .pylintrc: # We should clean up things so we can enable: # missing-docstring -- add lots of docstrings everywhere! [...] disable=3D missing-docstring, [...] I'm going to leave this as is for now.