From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0F5C51382C5 for ; Tue, 19 Jan 2021 14:58:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 448E7E0893; Tue, 19 Jan 2021 14:58:31 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DE750E0893 for ; Tue, 19 Jan 2021 14:58:30 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id by1so22507959ejc.0 for ; Tue, 19 Jan 2021 06:58:30 -0800 (PST) X-Gm-Message-State: AOAM532vk7nBs7CpbEzHN4djOWVsLxkskfQTYLhRNmY53Br/Ym2Bd08R V2RrqPKAJLBmWEeHQNlI/8iKlEDp2FhZ4tzhQ1U= X-Google-Smtp-Source: ABdhPJythJDKs/XdaUPLwVo268cjoEfy2FnUKxA/H51hN6robsEWNzIhbReUaxxAUPe9kAHjU0/qv27t+2heReOpGFU= X-Received: by 2002:a17:906:d8c3:: with SMTP id re3mr3388315ejb.80.1611068307102; Tue, 19 Jan 2021 06:58:27 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20210118202152.374078-1-mattst88@gentoo.org> <20210118202152.374078-11-mattst88@gentoo.org> In-Reply-To: From: Matt Turner Date: Tue, 19 Jan 2021 09:58:15 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 11/11] catalyst: Remove update_seed spec option To: Daniel Cordero Cc: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: 27f1e771-213d-426e-883c-444136cab57e X-Archives-Hash: 33973175f07ab06c451c04b3e240c1ad On Tue, Jan 19, 2021 at 6:04 AM Daniel Cordero wrote: > On Mon, Jan 18, 2021 at 03:21:52PM -0500, Matt Turner wrote: > > There should be no need for custom updates, and if there are exceptional > > circumstances the new --enter-chroot option can be used. > > > > There is still a need, and if I'm reading these patches right, > --enter-chroot would not satisfy that need. > > enter-chroot is interactive, and, depending on hardware speed, the time > between kicking off the catalyst run and when the chroot shell is > invoked may be some time for a human operator to monitor. > > It also adds non-deterministic, un-reproducible behaviour to a build. > Having it in the spec file at least means it is included in a build > artifact. Can you think of a case where update_seed would be needed? I tried, and couldn't think of anything, but I might not be imaginative enough. My thinking is that with @changed-subslots, there's essentially no need to update the seed stage further. But there have been some exceptional cases that don't really fit update_seed (e.g., things that cannot be fixed with emerge ...).