From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C19CB1381F3 for ; Fri, 11 Oct 2013 19:29:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F2AF0E0AB2; Fri, 11 Oct 2013 19:29:03 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 74400E0AB2 for ; Fri, 11 Oct 2013 19:29:03 +0000 (UTC) Received: from mail-qc0-f180.google.com (mail-qc0-f180.google.com [209.85.216.180]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mattst88) by smtp.gentoo.org (Postfix) with ESMTPSA id 5ED1033EFA4 for ; Fri, 11 Oct 2013 19:29:02 +0000 (UTC) Received: by mail-qc0-f180.google.com with SMTP id p19so3265667qcv.39 for ; Fri, 11 Oct 2013 12:29:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=iI6cYOszPg7ulxAFzI5FL74vwYpHDIFPgQHKqthp3Nk=; b=d5ph53P5twpAAR/uHXRuv0w0XV6mshcnqqBswvONzPwFuwUcZZ0F1V2olkV6XXR8m+ FVfwTOaviq0RwpPoB+vuQk3RY7OmdEAfYC18ma5oBf7k7vRkj5HQMaMjk9+cF47JEWCu yfd8k1qcTrAk86B2iOhCM7lnaJdUXUMJedj+umU07YC7LP6Wk+ZgKA0obOPS8sMQuHXF TbC5OxuuZVaVyg+2rqrPWp23Yz7hfMMrTyh1vhCojq0TU3u92Sd+anjCKuUxaqoC/0Ho G2/gYVt43s9Ju7ejM/hFJlihYGUT7Kdwdd4446gIjFf4fScw58Nm/RI5CRI6CJbUPgsO XPaQ== X-Received: by 10.229.101.136 with SMTP id c8mr21671459qco.17.1381519740705; Fri, 11 Oct 2013 12:29:00 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Received: by 10.49.17.6 with HTTP; Fri, 11 Oct 2013 12:28:40 -0700 (PDT) In-Reply-To: <1381515339.24205.73.camel@big_daddy.dol-sen.ca> References: <1381513107-17483-1-git-send-email-baker.dylan.c@gmail.com> <1381515339.24205.73.camel@big_daddy.dol-sen.ca> From: Matt Turner Date: Fri, 11 Oct 2013 12:28:40 -0700 Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 1/4] catalyst: Specify python2 rather than the generic python To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset=ISO-8859-1 X-Archives-Salt: c7d96edb-e3f5-4ecb-b60e-0c1aeafaa406 X-Archives-Hash: acffb4f936eed3589cc8ae52a3fdc222 On Fri, Oct 11, 2013 at 11:15 AM, Brian Dolbec wrote: > On Fri, 2013-10-11 at 10:38 -0700, Dylan Baker wrote: >> This allows catalyst to work regardless of whether a user prefers that >> usr/bin/python be python 2.x or 3.x. >> --- >> catalyst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/catalyst b/catalyst >> index 4550d05..11560fb 100755 >> --- a/catalyst >> +++ b/catalyst >> @@ -1,4 +1,4 @@ >> -#!/usr/bin/python -OO >> +#!/usr/bin/python2 -OO >> >> # Maintained in full by: >> # Catalyst Team > > > I'll reply to all 4 patches from this one. > > This is not needed due to the way python apps are wrapped during > install. bin/catalyst is renamed to bin/catalyst-python2.x and a > python-exec script replaces the original bin/catalyst. What do we gain by doing this in the ebuild's src_install() over doing it in? Because... > This is only > good for running the code directly from the git checkout. actually seems useful. We've had clearly broken commits go upstream, and if the author had been able to test from a git checkout we probably could have avoided that. > Also, we plan > to make the code python-3 capable as soon as a few more main code > changes are done. This isn't a reason to not specify the correct version of python. > As for the other patches, that work is already done in my rewrite and > will be taking over the master branch soon. It is the 3.0 branch which > has been rebased to the rewrite-on-master branch. There are a couple > rebase errors to fix on it still. > > http://git.overlays.gentoo.org/gitweb/?p=proj/catalyst.git Sounds like it shouldn't be any trouble to rebase on top of Dylan's patches, which are (pending the v2 of patch 2) read to be applied to master. What I mean is that I don't want to turn down contributions from new developers because there's a big backlog of work that hasn't gone upstream.