From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9551E15802F for ; Thu, 30 Mar 2023 12:56:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B6549E0907; Thu, 30 Mar 2023 12:56:41 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9CA7DE0907 for ; Thu, 30 Mar 2023 12:56:41 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id d14so8222374ion.9 for ; Thu, 30 Mar 2023 05:56:40 -0700 (PDT) X-Gm-Message-State: AAQBX9cOowbZ+wSs/ZZS1a5/8Hif7R7/uxnKKdOIb4rkYGogmM5xu2OX xJTCtwe5jqyssxgB5U0TdBfG4Wtq4uu16i3E6t4= X-Google-Smtp-Source: AKy350Y1ZYwX945mvqlDDbR3JWtk6XPABM/DnYb4CGAYI1scI32CV8IyVLgTfiRdd1PMvRpfjIh+75YRnxDLpYlRC8c= X-Received: by 2002:a6b:ef03:0:b0:75c:3b4b:eea3 with SMTP id k3-20020a6bef03000000b0075c3b4beea3mr5710702ioh.3.1680180998974; Thu, 30 Mar 2023 05:56:38 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20230329201418.2976304-1-bkohler@gentoo.org> In-Reply-To: <20230329201418.2976304-1-bkohler@gentoo.org> From: Matt Turner Date: Thu, 30 Mar 2023 08:56:27 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH] bootloader-setup.sh: remove obsolete cmdline args To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: ad276702-26ce-468d-a94d-aba754888eb1 X-Archives-Hash: 424bd8a1d119f6ee859c9a9034b5a289 On Wed, Mar 29, 2023 at 4:14=E2=80=AFPM Ben Kohler wro= te: > > These haven't been needed since kernel 2.4 days, as far as I know. > > Signed-off-by: Ben Kohler > --- > targets/support/bootloader-setup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/targets/support/bootloader-setup.sh b/targets/support/bootlo= ader-setup.sh > index 065f2bb5..32d86028 100755 > --- a/targets/support/bootloader-setup.sh > +++ b/targets/support/bootloader-setup.sh > @@ -53,7 +53,7 @@ memtest_grub() { > fi > } > > -default_append_line=3D(root=3D/dev/ram0 init=3D/linuxrc ${cmdline_opts[@= ]} cdroot) > +default_append_line=3D(${cmdline_opts[@]} cdroot) > > case ${clst_hostarch} in > alpha) > -- > 2.40.0 Looks like we add 'root=3D/dev/ram0 init=3D/linuxrc' a few lines below in the alpha-specific path as well. I wonder if we should drop it from there too? Otherwise, looks good to me.