From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-catalyst+bounces-3730-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id 9389B138359
for <garchives@archives.gentoo.org>; Fri, 23 Oct 2020 17:16:49 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id B3570E0893;
Fri, 23 Oct 2020 17:16:48 +0000 (UTC)
Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 99B0BE0893
for <gentoo-catalyst@lists.gentoo.org>; Fri, 23 Oct 2020 17:16:48 +0000 (UTC)
Received: by mail-ej1-f53.google.com with SMTP id p9so3392619eji.4
for <gentoo-catalyst@lists.gentoo.org>; Fri, 23 Oct 2020 10:16:47 -0700 (PDT)
X-Gm-Message-State: AOAM532tZP7iC/NokwIVEqGA8CLGYX8TSSTCX98WKXVMg9BriIk2z0vV
DCmnKUcxdkxML7y4ZSwyBXuz805csp8+NIubQwI=
X-Google-Smtp-Source: ABdhPJyxMN44Q0sgLbiqVOJVF5OGRXz8ykSZDLB3BoeV033zndtq5RFedD6rJecAT5Bg3rQ/xUVlyjfyEV1gorCSItA=
X-Received: by 2002:a17:906:234d:: with SMTP id m13mr3091908eja.497.1603473404951;
Fri, 23 Oct 2020 10:16:44 -0700 (PDT)
Precedence: bulk
List-Post: <mailto:gentoo-catalyst@lists.gentoo.org>
List-Help: <mailto:gentoo-catalyst+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-catalyst+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-catalyst+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-catalyst.gentoo.org>
X-BeenThere: gentoo-catalyst@lists.gentoo.org
Reply-to: gentoo-catalyst@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
References: <20201023091845.71295-1-gentoo.catalyst@xxoo.ws>
<20201023091845.71295-3-gentoo.catalyst@xxoo.ws> <CAEdQ38GqjQrV4ExmeTdS++79JQ6E+fgwwzL2YfJi94r_APMS5Q@mail.gmail.com>
<20201023170059.GB71925@dysnomia.localdomain>
In-Reply-To: <20201023170059.GB71925@dysnomia.localdomain>
From: Matt Turner <mattst88@gentoo.org>
Date: Fri, 23 Oct 2020 10:16:33 -0700
X-Gmail-Original-Message-ID: <CAEdQ38Hpty77a804rPSd4FbginJuZ_k4fLo8FrA6dFY_GFvbjw@mail.gmail.com>
Message-ID: <CAEdQ38Hpty77a804rPSd4FbginJuZ_k4fLo8FrA6dFY_GFvbjw@mail.gmail.com>
Subject: Re: [gentoo-catalyst] [PATCH 3/3] Build ISO with Joliet directory information
To: gentoo-catalyst@lists.gentoo.org
Content-Type: text/plain; charset="UTF-8"
X-Archives-Salt: 83accbbe-4d99-455a-a867-35db99b4843b
X-Archives-Hash: df411f2618a67387292ebb4d5805215f
On Fri, Oct 23, 2020 at 10:01 AM Daniel Cordero <gentoo.catalyst@xxoo.ws> wrote:
>
> On Fri, Oct 23, 2020 at 09:25:29AM -0700, Matt Turner wrote:
> > On Fri, Oct 23, 2020 at 2:19 AM Daniel Cordero <gentoo.catalyst@xxoo.ws> wrote:
> > >
> > > From: Daniel Cordero <catalyst@0xdc.io>
> > >
> > > Previous syslinux based CDs had this information.
> > > Necessary for direct kernel booting with virt-install --location.
> > >
> > > Fixes: 0a27a7a39a "targets: Use GRUB for BIOS boot"
> > >
> > > Signed-off-by: Daniel Cordero <catalyst@0xdc.io>
> > > ---
> > > targets/support/create-iso.sh | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
> > > index 9b1c7185..b11b046f 100755
> > > --- a/targets/support/create-iso.sh
> > > +++ b/targets/support/create-iso.sh
> > > @@ -192,6 +192,7 @@ case ${clst_hostarch} in
> > > isoroot_checksum
> > >
> > > case ${clst_hostarch} in
> > > + amd64|x86) extra_opts="-joliet" ;;
> >
> > Is there any reason to limit this to amd64/x86?
> >
>
> My concern is that the other arches may not have had this information on
> their ISOs. I do not know if those arches might not like it.
Oh, I see: this flag is passed through grub-mkrescue to mkisofs. I
guess this is an alias for the -J flag to mkisofs? Strange that I
don't see it documented in either mkisofs(8) or grub-mkrescue(1). It
looks like we're passing -J to mkisofs/xorriso on alpha and hppa, so
my feeling is that we should just use it on all platforms. I'm happy
to adjust the patch when I commit it.