Hi Mikeļ¼Œ I've tesed Kevin Zhao's patches Could you help me to review v3 patches and merge to upstream ? These patches will be sent in mail list later.... Thanks *Leno Hou* On Tue, Jan 12, 2016 at 10:31 PM, Kevin Zhao wrote: > Hi Mike, > Thanks for your comment.I have send a new patch cover this :-) > > 2016-01-09 3:50 GMT+08:00 Mike Frysinger : > > On 08 Jan 2016 05:04, Kevin Zhao wrote: > >> + if echo ${clst_subarch} | grep -qE ".+le$" > > > > just use a pattern match: > > if [[ ${clst_subarch} == *le ]] > > > >> + then > >> + flags+=( > >> + -v -T -l -cache-inodes -chrp-boot > >> + ) > > > > -chrp-boot shows up in both, so factor that out into the common setting ? > > > >> + flags+=( > >> + -chrp-boot -netatalk -hfs -probe -map > "${clst_target_path}"/boot/map.hfs \ > > > > you don't need to use \ with arrays > > -mike > >