From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 41AEC1381F3 for ; Thu, 21 Apr 2016 04:41:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 82CCD21C010; Thu, 21 Apr 2016 04:41:58 +0000 (UTC) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D9C6721C010 for ; Thu, 21 Apr 2016 04:41:57 +0000 (UTC) Received: by mail-lf0-f65.google.com with SMTP id e190so6913821lfe.1 for ; Wed, 20 Apr 2016 21:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yqN58xxe2gRhxaei8BcxDPYVKo6Xasgnfzp/L4TlSME=; b=b24PZBe3n7DnS4n3BC3cmTCXwRYwJlVwXPC3A/ESmdqwk76gKd1tMgRe0MPzPrKcsW DU5ULeAIiIbO0kvZ0FhvIvq4QPdkMkrOiIZ2M1SM8/1FX62hDqEIqbqZoObMDkQBmwY8 Nv/j6mSKj2edyiGypwZJyb599tSBUc5LPMyzmjta0SBUfCaLnVh0nPht6doXw1km2Cla tg9OwVBr2Uj2S+DF9ju8FyNOaLB4/WEnJGC5j5CK+U7BOeNy4OkdDr5uRLHjAheN8Bm1 /p02P1E5ktVt9qfOVPoShEMrptvtMZKtq/4NUySmbM/toygL13HTlYOIJ1xTLUeOy9rI av6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yqN58xxe2gRhxaei8BcxDPYVKo6Xasgnfzp/L4TlSME=; b=XBpuIHAmlivXf0+23WcShM1O7/MCIlCHJpI9HxVjybsIZa9A3Uj2kTaQDivnF7aa6x ddYM+rWPy8skS5ulJCQl4GyiMz5iAYB59608SaqJM8KEj57JisKk5HiK/gpxsGL6Gwsl dc5g++CcM8TX9+irAB8OfDXxv4rPSeNItFuWTOBem6vBwPnJnjkB/TCGy37yP9TKH7Yb ElNmsb38P+uZwpQC+QMvMy5iR+zpO1kTQIqv7ZQXN0LB5rClfm2ikPsQyAcwSPn5uLs6 s7+bo/OsA73gemcAd5VjpOyFm3ZWp0D9zlkeSP5Rimnvqakw3/U9krf1SgGUQsriaXlz AVsA== X-Gm-Message-State: AOPr4FV61NwsASEWFDFMaDs2bPBNlYY5hcUMt4psuLbF9YTr54WQJyJTTCB33/vAlPS6TFr3fJ8v3sSb9TTDkg== X-Received: by 10.25.90.79 with SMTP id o76mr5388043lfb.9.1461213716199; Wed, 20 Apr 2016 21:41:56 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Received: by 10.25.19.72 with HTTP; Wed, 20 Apr 2016 21:41:36 -0700 (PDT) In-Reply-To: References: <1452247437-14820-1-git-send-email-kevin.zhaoshuai@gmail.com> <1452247450-14865-1-git-send-email-kevin.zhaoshuai@gmail.com> <20160108195042.GM25548@vapier.lan> From: Leno Hou Date: Thu, 21 Apr 2016 12:41:36 +0800 Message-ID: Subject: Re: [gentoo-catalyst][PATCH 2/3] Modify the parameter of ppc64 little-endian, because the ppc64 little-endian has different archtecture and new boot parameters.Don't need the hfs and mapping files as it in Big-endian.Also tweak the code of Big-endian. To: gentoo-catalyst@lists.gentoo.org, Mike Frysinger Cc: Kevin Zhao Content-Type: multipart/alternative; boundary=001a1140027a7ebea50530f7548e X-Archives-Salt: 3fc72612-26e7-49c6-81cb-5daf91e2e5d4 X-Archives-Hash: 18ff3d91e6890bcc7fb09d7052bfd381 --001a1140027a7ebea50530f7548e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Mike=EF=BC=8C I've tesed Kevin Zhao's patches Could you help me to review v3 patches and merge to upstream ? These patches will be sent in mail list later.... Thanks *Leno Hou* On Tue, Jan 12, 2016 at 10:31 PM, Kevin Zhao wrote: > Hi Mike, > Thanks for your comment.I have send a new patch cover this :-) > > 2016-01-09 3:50 GMT+08:00 Mike Frysinger : > > On 08 Jan 2016 05:04, Kevin Zhao wrote: > >> + if echo ${clst_subarch} | grep -qE ".+le$" > > > > just use a pattern match: > > if [[ ${clst_subarch} =3D=3D *le ]] > > > >> + then > >> + flags+=3D( > >> + -v -T -l -cache-inodes -chrp-boot > >> + ) > > > > -chrp-boot shows up in both, so factor that out into the common setting= ? > > > >> + flags+=3D( > >> + -chrp-boot -netatalk -hfs -probe -map > "${clst_target_path}"/boot/map.hfs \ > > > > you don't need to use \ with arrays > > -mike > > --001a1140027a7ebea50530f7548e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Mike=EF=BC=8C

=C2=A0 =C2= =A0 I've tesed Kevin Zhao's patches Could you help me to review v3 = patches and merge to upstream ?
=C2=A0 =C2=A0 These patches will = be sent in mail list later.... Thanks

Leno Hou

On Tue, Jan 12, 2016 at 10:31 PM, Kevin Zhao= <kevin.zhaoshuai@gmail.com> wrote:
Hi Mike,
=C2=A0 =C2=A0 Thanks for your comment.I have send a new patch cover this :-= )

2016-01-09 3:50 GMT+08:00 Mike Frysinger <vapier@gentoo.org>:
> On 08 Jan 2016 05:04, Kevin Zhao wrote:
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if echo ${clst_su= barch} | grep -qE ".+le$"
>
> just use a pattern match:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if [[ ${clst_subarch} =3D=3D *le ]] >
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0then
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0flags+=3D(
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-v -T -l -cache-inodes -chrp-boot<= br> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0)
>
> -chrp-boot shows up in both, so factor that out into the common settin= g ?
>
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0flags+=3D(
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-chrp-boot -netatalk -hfs -probe -= map "${clst_target_path}"/boot/map.hfs \
>
> you don't need to use \ with arrays
> -mike


--001a1140027a7ebea50530f7548e--