From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F2CDF15802F for ; Wed, 29 Mar 2023 19:40:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 186E02BC045; Wed, 29 Mar 2023 19:40:26 +0000 (UTC) Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0AA592BC045 for ; Wed, 29 Mar 2023 19:40:25 +0000 (UTC) Received: by mail-ot1-x334.google.com with SMTP id x8-20020a9d3788000000b0069f922cd5ceso8819108otb.12 for ; Wed, 29 Mar 2023 12:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680118823; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=431/d74S/cHQYw6KavpuVgmJuD0JbZHcTpbmAVkgCK4=; b=AaHfDIGexdQ2+lliwE31t3LC8IlTd4pNhRkxICJmAam+vcxVc4/MnjBt6IimxDKl99 nwVQ6sZ0ohh9OAIuJtKZxTY3pOzeJisTtSdicbynidJsnrXHudXjRxyFmuIYX0umZ4es Fg3dh40oCAp6Zf/8h/4XT8Ovz9pdRX24+Gb0aSaQvOQmb/q8zfkqlod7KtcWf8k/aVwT hL9I4KgBBM4iVallpW2vmpO1iCArgfOUK5OrRDbrUOLDPVp13/kR1Kq1fZ2LXF3Z/9/l QjN0lXb3WcfTlwA4YPlaLRqLTF9ag6NWDJ/CQt1WcYh3TdeG+oizLkRLx6fQRPHP59YD L++Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680118823; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=431/d74S/cHQYw6KavpuVgmJuD0JbZHcTpbmAVkgCK4=; b=Hs+h0hEVwcRwyz/ZKvPsipIitrEvSu+0JSQ1c5xf3N9b2IGZpDMWEXM1QopNNaEU8k etwwZqd2m6wmA5FCiYnfb5ZGSDYTObu8+cl2P/lMNwh6isRjyEqZSaQAsZxySi+RS5UM rTI0+gZHwyvTTz75WY/bLTWAgz7kOR11jpU6KDImAMZPhsFf00uZr27PbUqfJRN54R9J 9bsq4fmM/8kuhfA0s6YemwiGgFpDQg7chAeNuoF1OeTpu4uGqmzyopT7rWwTSeJQ93pG jvO2KxeZyFaFQfba25rqZy9IBVZW2VetkMsIHceZR9o864LdXEZR5RaMYqKvy9Ma/Erm RZxw== X-Gm-Message-State: AO0yUKWap88qjnOIN3U0zww182d8JB4ID2s26o/6kAY3fBCFJmGEhSPZ sBv7Z3dKDWTx2n/TNj5BI1Rwm21wxRCjql1z1efi6jlQ X-Google-Smtp-Source: AK7set8DoKkukvoDnhU8kfCob4YaUNjp6CzNdcrUYryR+7MikeEJXadYOOMWXLbR0TQ8W32q9XgzZTSOD2bMooJpC7g= X-Received: by 2002:a9d:66d1:0:b0:69f:bac:aa8a with SMTP id t17-20020a9d66d1000000b0069f0bacaa8amr6933388otm.2.1680118823736; Wed, 29 Mar 2023 12:40:23 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20230329193100.2976079-1-bkohler@gentoo.org> <20230329193100.2976079-5-bkohler@gentoo.org> In-Reply-To: <20230329193100.2976079-5-bkohler@gentoo.org> From: Christian Iwata Nilsson Date: Wed, 29 Mar 2023 21:40:11 +0200 Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 05/10] livecdfs-update.sh: remove net.eth[1234] symlinks To: gentoo-catalyst@lists.gentoo.org Content-Type: multipart/alternative; boundary="000000000000ab59ae05f80f2525" X-Archives-Salt: 94eabf58-b782-4289-9327-5feea21fd2cb X-Archives-Hash: 53e58b5e27e400f2381a31231370e9d8 --000000000000ab59ae05f80f2525 Content-Type: text/plain; charset="UTF-8" Don't know if it applies, but I always start systems (and livecds) without the (un)predictablenetworknames brokenness. So that it is always ethx and nothing else. So before removing this, I would like to ask to please ensure that scenario keeps working. On Wed, 29 Mar 2023, 21:31 Ben Kohler, wrote: > I don't think these are providing any value to anyone, since interfaces > don't get eth* names by default and very few livecd users will be using > netifrc anyway. > > Signed-off-by: Ben Kohler > --- > targets/support/livecdfs-update.sh | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/targets/support/livecdfs-update.sh > b/targets/support/livecdfs-update.sh > index 9e0fd6cc..ca8997f7 100755 > --- a/targets/support/livecdfs-update.sh > +++ b/targets/support/livecdfs-update.sh > @@ -60,12 +60,6 @@ then > sed -i '/NOPASSWD: ALL/ s/^# //' /etc/sudoers > fi > > -# Setup links for ethernet devices > -cd /etc/init.d > -for i in {1..4}; do > - ln -sf net.lo net.eth${i} > -done > - > # Add this for hwsetup/mkx86config > mkdir -p /etc/sysconfig > > -- > 2.40.0 > > > --000000000000ab59ae05f80f2525 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Don't know if it applies, but I always start systems = (and livecds)=C2=A0without th= e (un)predictablenetworknames brokenness. So that it is always ethx and not= hing else.

So before removing = this, I would like to ask to please ensure that scenario keeps working.

On Wed, 29 Mar 2023, 21:31 Ben Kohler, <bkohler@gentoo.org> wrote:
I don't think these are providing any value to anyone, since int= erfaces
don't get eth* names by default and very few livecd users will be using=
netifrc anyway.

Signed-off-by: Ben Kohler <bkohler@gentoo.org>
---
=C2=A0targets/support/livecdfs-update.sh | 6 ------
=C2=A01 file changed, 6 deletions(-)

diff --git a/targets/support/livecdfs-update.sh b/targets/support/livecdfs-= update.sh
index 9e0fd6cc..ca8997f7 100755
--- a/targets/support/livecdfs-update.sh
+++ b/targets/support/livecdfs-update.sh
@@ -60,12 +60,6 @@ then
=C2=A0 =C2=A0 =C2=A0 =C2=A0 sed -i '/NOPASSWD: ALL/ s/^# //' /etc/s= udoers
=C2=A0fi

-# Setup links for ethernet devices
-cd /etc/init.d
-for i in {1..4}; do
-=C2=A0 =C2=A0 =C2=A0 =C2=A0ln -sf net.lo net.eth${i}
-done
-
=C2=A0# Add this for hwsetup/mkx86config
=C2=A0mkdir -p /etc/sysconfig

--
2.40.0


--000000000000ab59ae05f80f2525--