From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-catalyst+bounces-3437-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 07B131388BF
	for <garchives@archives.gentoo.org>; Tue, 12 Jan 2016 14:31:20 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 5F22421C001;
	Tue, 12 Jan 2016 14:31:18 +0000 (UTC)
Received: from mail-lb0-f195.google.com (mail-lb0-f195.google.com [209.85.217.195])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id D791321C001
	for <gentoo-catalyst@lists.gentoo.org>; Tue, 12 Jan 2016 14:31:17 +0000 (UTC)
Received: by mail-lb0-f195.google.com with SMTP id oe3so1896177lbb.1
        for <gentoo-catalyst@lists.gentoo.org>; Tue, 12 Jan 2016 06:31:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=mlSYm3GkTkunVh4LrD7chFcrC5s4Otru/E6CsKY3EMc=;
        b=XD188F/MRAYXKdhDkRj3UJhr5ZBHdxS8rZJMmPoiCjFynfmghC/ONHXWwPM9Jxnpae
         cx9CZcfK/7FghtNZMvqDPNmUfLaf7Gh5u6UF187CGvupH/LdHech+3Xpg0Fvg3NpyzAV
         fNi0GXtsB65PbEMlkcWq5QXvo1uNbZhjl4oAIMnppF/w/xdJlF2UvyjuwGUjHX3e8wfq
         3S4lP291lbaVGhVGERn7L4NoEf0VL2z1Yk6zRxLVvxLuNolM31OAD/k8YyTyQibMfLbe
         jQMDvNwMVkESElPWOdod6v0HJpyIAqqBL5A3xxlXABMc9lKkX/OJuoEwm8SkqkhwAIb2
         5ZJQ==
Precedence: bulk
List-Post: <mailto:gentoo-catalyst@lists.gentoo.org>
List-Help: <mailto:gentoo-catalyst+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-catalyst+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-catalyst+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-catalyst.gentoo.org>
X-BeenThere: gentoo-catalyst@lists.gentoo.org
Reply-to: gentoo-catalyst@lists.gentoo.org
MIME-Version: 1.0
X-Received: by 10.112.161.10 with SMTP id xo10mr6795978lbb.131.1452609076352;
 Tue, 12 Jan 2016 06:31:16 -0800 (PST)
Received: by 10.25.28.15 with HTTP; Tue, 12 Jan 2016 06:31:16 -0800 (PST)
In-Reply-To: <20160108195042.GM25548@vapier.lan>
References: <1452247437-14820-1-git-send-email-kevin.zhaoshuai@gmail.com>
	<1452247450-14865-1-git-send-email-kevin.zhaoshuai@gmail.com>
	<20160108195042.GM25548@vapier.lan>
Date: Tue, 12 Jan 2016 22:31:16 +0800
Message-ID: <CAKe2hGDnJ7Y48qtVKM1EYf1=D7DUio0mV7grwFZwPBQyq0oU3A@mail.gmail.com>
Subject: Re: [gentoo-catalyst][PATCH 2/3] Modify the parameter of ppc64
 little-endian, because the ppc64 little-endian has different archtecture and
 new boot parameters.Don't need the hfs and mapping files as it in
 Big-endian.Also tweak the code of Big-endian.
From: Kevin Zhao <kevin.zhaoshuai@gmail.com>
To: gentoo-catalyst@lists.gentoo.org, Kevin Zhao <kevin.zhaoshuai@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-Archives-Salt: 273e713e-1bdc-4870-8ae2-793336dfa974
X-Archives-Hash: 6373ae8ef363d5eb8c9ba238f6af3181

Hi Mike,
    Thanks for your comment.I have send a new patch cover this :-)

2016-01-09 3:50 GMT+08:00 Mike Frysinger <vapier@gentoo.org>:
> On 08 Jan 2016 05:04, Kevin Zhao wrote:
>> +             if echo ${clst_subarch} | grep -qE ".+le$"
>
> just use a pattern match:
>         if [[ ${clst_subarch} == *le ]]
>
>> +             then
>> +                     flags+=(
>> +                             -v -T -l -cache-inodes -chrp-boot
>> +                     )
>
> -chrp-boot shows up in both, so factor that out into the common setting ?
>
>> +                     flags+=(
>> +                             -chrp-boot -netatalk -hfs -probe -map "${clst_target_path}"/boot/map.hfs \
>
> you don't need to use \ with arrays
> -mike