public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Kevin Zhao <kevin.zhaoshuai@gmail.com>
To: gentoo-catalyst@lists.gentoo.org, Zhao Kevin <kevin.zhaoshuai@gmail.com>
Subject: Re: [gentoo-catalyst][PATCH v1 2/3] Modify the create iso parameter of ppc64le and power8
Date: Thu, 7 Jan 2016 10:35:55 +0800	[thread overview]
Message-ID: <CAKe2hGDo-E9D8LNUz4L9tgrfGoHsfUbbg63A=SqtEsAQ=rSQgA@mail.gmail.com> (raw)
In-Reply-To: <20160105233047.GP25548@vapier.lan>

2016-01-06 7:30 GMT+08:00 Mike Frysinger <vapier@gentoo.org>:
> On 16 Dec 2015 11:41, Kevin Zhao wrote:
>> -             run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid "${clst_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs "zisofs" -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/
>> +             if [ "${clst_subarch}" == "ppc64le" ]||[ "${clst_subarch}" == "power8" ]
>
> please put spaces around the || operator, and use = instead of ==
>
> isn't this power8 specific ?  so do you really need to look at ppc64le ?

Thanks for the comment Mike. It is not the power8 specific, all the
ppc64le arch(including power7le and power8le)will use the new command

>
>> +             then
>> +                     run_mkisofs -v -r -T -U -l -cache-inodes -chrp-boot -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"
>> +             else
>> +                     run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid "${clst_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs "zisofs" -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/
>> +             fi
>
> i know the existing code is ugly, but please fix that here.  rather than
> duplicate the huge command line, factor out the common bits.  something
> like:
>         flags=( -r -U )
>         if [ "${clst_subarch}" = "power8" ]
>         then
>                 flags+=(
>                         -v -T -l -cache-inodes -chrp-boot
>                 )
>         else
>                 flags+=(
>                         ...
>                 )
>         fi
>         run_mkisofs "${flags[@]}" \
>                 -J ${mkisofs_zisofs_opts}
>                 -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"
>
> also, it seems like some of the flags you dropped for power8 should stay there.
> -mike
OK I will fix it here.Thanks~I will send the modifying patches again
after tweaking.


      reply	other threads:[~2016-01-07  2:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 16:40 [gentoo-catalyst][PATCH v1 1/3] Add an subarch ppc64le,as the little-endian of ppc64 Kevin Zhao
2015-12-16 16:41 ` [gentoo-catalyst][PATCH v1 2/3] Modify the create iso parameter of ppc64le and power8 Kevin Zhao
2016-01-05 23:30   ` Mike Frysinger
2016-01-07  2:35     ` Kevin Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKe2hGDo-E9D8LNUz4L9tgrfGoHsfUbbg63A=SqtEsAQ=rSQgA@mail.gmail.com' \
    --to=kevin.zhaoshuai@gmail.com \
    --cc=gentoo-catalyst@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox