From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-catalyst+bounces-2835-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
by finch.gentoo.org (Postfix) with ESMTP id 46E67138247
for <garchives@archives.gentoo.org>; Sat, 14 Dec 2013 16:07:56 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 1D972E0B04;
Sat, 14 Dec 2013 16:07:55 +0000 (UTC)
Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com [209.85.212.53])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 8EF15E0B04
for <gentoo-catalyst@lists.gentoo.org>; Sat, 14 Dec 2013 16:07:54 +0000 (UTC)
Received: by mail-vb0-f53.google.com with SMTP id o19so2130993vbm.12
for <gentoo-catalyst@lists.gentoo.org>; Sat, 14 Dec 2013 08:07:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20120113;
h=mime-version:in-reply-to:references:date:message-id:subject:from:to
:content-type;
bh=yBM0B8atebCMhUnJihWOoJnUWCmgk/wHkdHNHBktY+k=;
b=lUDZf1oHFeySv3nZA2V01WOJEHktWKAkS6Z1uWKBGuGCOdRFnAdwPCJwI+1Ht951Za
rfp9rFeajacflwX+SPW9mDVjDpoL51H6F/gWt+XSj/zFLH+JIOjeRmRAUxRd/R3HRWDy
Xv0WUBOphQJQGI/ALgfCyB5tevyh1NomFEz652c8tM24/gZx36ypz7nj99gKGF0VQcCx
yX7jP5ZLXISTKTeNL/WHxvlnp0DomxQ2bQa9dHLAbDnlqkjShZebeK9ZkFNmTNog2dqQ
HAV2jLkwDE260FuesoarsHcWDXsxZ7hvDmslGBCzGanDmGsdnUudNCxMR5uV/vjoEyTh
QhDg==
Precedence: bulk
List-Post: <mailto:gentoo-catalyst@lists.gentoo.org>
List-Help: <mailto:gentoo-catalyst+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-catalyst+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-catalyst+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-catalyst.gentoo.org>
X-BeenThere: gentoo-catalyst@lists.gentoo.org
Reply-to: gentoo-catalyst@lists.gentoo.org
MIME-Version: 1.0
X-Received: by 10.58.146.71 with SMTP id ta7mr121734veb.23.1387037273915; Sat,
14 Dec 2013 08:07:53 -0800 (PST)
Received: by 10.58.237.163 with HTTP; Sat, 14 Dec 2013 08:07:53 -0800 (PST)
In-Reply-To: <693519560.0lWei86J99@moiraine>
References: <1386990436-9198-1-git-send-email-dolsen@gentoo.org>
<1386990436-9198-4-git-send-email-dolsen@gentoo.org>
<693519560.0lWei86J99@moiraine>
Date: Sat, 14 Dec 2013 08:07:53 -0800
Message-ID: <CANss4CoXi5piPaQr1LEpEGFhj5Fi3RbgHZXDN1V+LQ4Qzkcg0A@mail.gmail.com>
Subject: Re: [gentoo-catalyst] [PATCH 3/4] Adapt commit c52962b6bd2 to use the
new configured settings values.
From: Dylan Baker <baker.dylan.c@gmail.com>
To: gentoo-catalyst@lists.gentoo.org
Content-Type: multipart/alternative; boundary=047d7b5d4a3000874704ed80c8b8
X-Archives-Salt: f06c540d-1879-46c5-b9ff-6ceffa918131
X-Archives-Hash: 61dac1a787c93da5d19a61e3d4b4e5cf
--047d7b5d4a3000874704ed80c8b8
Content-Type: text/plain; charset=ISO-8859-1
Please ignore my last email. I should drink my coffee *before* I begin
reviewing patches.
On Sat, Dec 14, 2013 at 6:54 AM, Dylan Baker <baker.dylan.c@gmail.com>wrote:
> On Friday, December 13, 2013 07:07:15 PM Brian Dolbec wrote:
> > ---
> > modules/generic_stage_target.py | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/modules/generic_stage_target.py
> > b/modules/generic_stage_target.py index 342c65b..1fbc733 100644
> > --- a/modules/generic_stage_target.py
> > +++ b/modules/generic_stage_target.py
> > @@ -1066,9 +1066,9 @@ class generic_stage_target(generic_target):
> > "/use will cause portage
> to ignore"
> > print "\tpackage.use in the
> profile and portage_confdir.
> You've been
> > warned!"
> >
> > - myf.write('PORTDIR="/usr/portage"\n')
> > - myf.write('DISTDIR="${PORTDIR}/distfiles"\n')
> > - myf.write('PKGDIR="${PORTDIR}/packages"\n')
> > + myf.write('PORTDIR="%s"\n' %
> self.settings['portdir'])
> > + myf.write('DISTDIR="%s"\n' %
> self.settings['distdir'])
> > + myf.write('PKGDIR="%s"\n' %
> self.settings['packagedir'])
>
> what is the point of this? These produce exactly the same output, except
> the
> previous is more readable.
>
> >
> > """ Setup the portage overlay """
> > if "portage_overlay" in self.settings:
>
--047d7b5d4a3000874704ed80c8b8
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Please ignore my last email. I should drink my coffee *bef=
ore* I begin reviewing patches.</div><div class=3D"gmail_extra"><br><br><di=
v class=3D"gmail_quote">On Sat, Dec 14, 2013 at 6:54 AM, Dylan Baker <span =
dir=3D"ltr"><<a href=3D"mailto:baker.dylan.c@gmail.com" target=3D"_blank=
">baker.dylan.c@gmail.com</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div class=3D"HOEnZb"><div class=3D"h5">On F=
riday, December 13, 2013 07:07:15 PM Brian Dolbec wrote:<br>
> ---<br>
> =A0modules/generic_stage_target.py | 6 +++---<br>
> =A01 file changed, 3 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/modules/generic_stage_target.py<br>
> b/modules/generic_stage_target.py index 342c65b..1fbc733 100644<br>
> --- a/modules/generic_stage_target.py<br>
> +++ b/modules/generic_stage_target.py<br>
> @@ -1066,9 +1066,9 @@ class generic_stage_target(generic_target):<br>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 "/use will cause portage to ignore"<br>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 print "\tpackage.use in the profile and portage_confdir.<br>
You've been<br>
> warned!"<br>
><br>
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 myf.write('PORTDIR=3D&qu=
ot;/usr/portage"\n')<br>
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 myf.write('DISTDIR=3D&qu=
ot;${PORTDIR}/distfiles"\n')<br>
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 myf.write('PKGDIR=3D&quo=
t;${PORTDIR}/packages"\n')<br>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 myf.write('PORTDIR=3D&qu=
ot;%s"\n' % self.settings['portdir'])<br>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 myf.write('DISTDIR=3D&qu=
ot;%s"\n' % self.settings['distdir'])<br>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 myf.write('PKGDIR=3D&quo=
t;%s"\n' % self.settings['packagedir'])<br>
<br>
</div></div>what is the point of this? These produce exactly the same outpu=
t, except the<br>
previous is more readable.<br>
<div class=3D"HOEnZb"><div class=3D"h5"><br>
><br>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 """ Setup t=
he portage overlay """<br>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if "portage_overlay&q=
uot; in self.settings:<br>
</div></div></blockquote></div><br></div>
--047d7b5d4a3000874704ed80c8b8--