From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 990421382C5 for ; Thu, 21 Jan 2021 10:20:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BC828E0815; Thu, 21 Jan 2021 10:20:50 +0000 (UTC) Received: from rs234.mailgun.us (rs234.mailgun.us [209.61.151.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4E489E0815 for ; Thu, 21 Jan 2021 10:20:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=xxoo.ws; q=dns/txt; s=mx; t=1611224450; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=g+8KAkBChEvaFeisJwfER8JIlZLm+lgAATcgVSzr9Ew=; b=hOrGVoaAOxjU1V6PvLT0fVn9ePrL6UMcpFME7EC+UrL/33KsswTeODzSb6CUo1yMx2KlHryl 30KNhVvgNeRUwy0quOnolX8hQyxW0cqkmBDZrU1RBozgogctQUha8HUM/6LYS7mptUTfL/k6 z3ThjiKLm4YJqdW3x84NHCS5zbk= X-Mailgun-Sending-Ip: 209.61.151.234 X-Mailgun-Sid: WyIxYmU3MyIsICJnZW50b28tY2F0YWx5c3RAbGlzdHMuZ2VudG9vLm9yZyIsICJlYTQwNTYiXQ== Received: from mail.0xdc.io (ip-54-37-0.eu [54.37.0.172]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 6009557b5677aca7bd13fc01 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 21 Jan 2021 10:20:43 GMT Sender: gentoo.catalyst@xxoo.ws Received: from dysnomia (7.3.b.e.5.8.9.6.c.e.c.8.c.d.8.7.0.a.4.7.9.0.c.0.0.b.8.0.1.0.0.2.ip6.arpa [IPv6:2001:8b0:c09:74a0:78dc:8cec:6985:eb37]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.0xdc.io (Postfix) with ESMTPSA id C588310239F; Thu, 21 Jan 2021 10:20:43 +0000 (UTC) Date: Thu, 21 Jan 2021 10:20:38 +0000 From: Daniel Cordero To: Matt Turner Cc: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 11/11] catalyst: Remove update_seed spec option Message-ID: References: <20210118202152.374078-1-mattst88@gentoo.org> <20210118202152.374078-11-mattst88@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Archives-Salt: 662ffd50-b64e-4c85-83a4-a53cabd163ce X-Archives-Hash: cc540f8b2c40ce2d85f3e7d6be6e97d4 On Tue, Jan 19, 2021 at 09:58:15AM -0500, Matt Turner wrote: > On Tue, Jan 19, 2021 at 6:04 AM Daniel Cordero wrote: > > On Mon, Jan 18, 2021 at 03:21:52PM -0500, Matt Turner wrote: > > > There should be no need for custom updates, and if there are exceptional > > > circumstances the new --enter-chroot option can be used. > > > > > > > There is still a need, and if I'm reading these patches right, > > --enter-chroot would not satisfy that need. > > > > enter-chroot is interactive, and, depending on hardware speed, the time > > between kicking off the catalyst run and when the chroot shell is > > invoked may be some time for a human operator to monitor. > > > > It also adds non-deterministic, un-reproducible behaviour to a build. > > Having it in the spec file at least means it is included in a build > > artifact. > > Can you think of a case where update_seed would be needed? I tried, > and couldn't think of anything, but I might not be imaginative enough. > > My thinking is that with @changed-subslots, there's essentially no > need to update the seed stage further. But there have been some > exceptional cases that don't really fit update_seed (e.g., things that > cannot be fixed with emerge ...). update_seed has been very useful when dealing with perl/python version upgrades, where large swathes of packages need to be updated at the same time. I'm not sure if @changed-subslots has in any way resolved this, but it's convenient to have an override. Another example was a recent bash/readline update, where the stage3 had readline.so.5 and built the new stage1 bash against that, but installed readline.so.6 into the stage1root, hence the stage2 build was broken.