[gentoo-catalyst] ccache cache deleted during stage2 build

[gentoo-catalyst] ccache cache deleted during stage2 build

[Tom Stellard]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

I am using the latest version of catalyst from git(commit
16745ae35961557a1205b5c86419d1aa496fcdf7).  I noticed that when the
stage2-preclean-chroot.sh script calls cleanup_stages() in
chroot_functions.sh, it deletes everything in $CHROOT_PATH/var/tmp,
but since $CHROOT_PATH/var/tmp/ccache is still bound to
/var/tmp/ccache my cache that lives outside of the chroot is cleared
as well. I have attached a patch that appears to fix the problem.  I
am not sure if there are any ill side-effects from this patch, but
since the "clean" action sequence also clears /var/tmp/*, is it really
necessary to do it in the stage2-preclean-chroot.sh script?

-Tom Stellard

[-- Attachment #2: catalyst.diff --]
[-- Type: text/plain, Size: 350 bytes --]

diff --git a/targets/support/chroot-functions.sh b/targets/support/chroot-functions.sh
index f91f53c..fe20194 100644
--- a/targets/support/chroot-functions.sh
+++ b/targets/support/chroot-functions.sh
@@ -210,7 +210,6 @@ cleanup_stages() {
 	esac
 
 	rm -f /var/log/emerge.log /var/log/portage/elog/*
-	rm -rf /var/tmp/*
 }
 
 update_env_settings(){

Re: [gentoo-catalyst] ccache cache deleted during stage2 build

[Andrew Gaffney]

Please file a bug about this.

Tom Stellard wrote:
> I am using the latest version of catalyst from git(commit
> 16745ae35961557a1205b5c86419d1aa496fcdf7).  I noticed that when the
> stage2-preclean-chroot.sh script calls cleanup_stages() in
> chroot_functions.sh, it deletes everything in $CHROOT_PATH/var/tmp,
> but since $CHROOT_PATH/var/tmp/ccache is still bound to
> /var/tmp/ccache my cache that lives outside of the chroot is cleared
> as well. I have attached a patch that appears to fix the problem.  I
> am not sure if there are any ill side-effects from this patch, but
> since the "clean" action sequence also clears /var/tmp/*, is it really
> necessary to do it in the stage2-preclean-chroot.sh script?
> 
> -Tom Stellard
> 


-- 
Andrew Gaffney                                 http://dev.gentoo.org/~agaffney/
Gentoo Linux Developer            Catalyst/Genkernel + Release Engineering Lead

Re: [gentoo-catalyst] ccache cache deleted during stage2 build

[Tom Stellard]

On Wed, Apr 1, 2009 at 11:18 AM, Andrew Gaffney <agaffney@gentoo.org> wrote:
> Please file a bug about this.
>
> Tom Stellard wrote:
>> I am using the latest version of catalyst from git(commit
>> 16745ae35961557a1205b5c86419d1aa496fcdf7).  I noticed that when the
>> stage2-preclean-chroot.sh script calls cleanup_stages() in
>> chroot_functions.sh, it deletes everything in $CHROOT_PATH/var/tmp,
>> but since $CHROOT_PATH/var/tmp/ccache is still bound to
>> /var/tmp/ccache my cache that lives outside of the chroot is cleared
>> as well. I have attached a patch that appears to fix the problem.  I
>> am not sure if there are any ill side-effects from this patch, but
>> since the "clean" action sequence also clears /var/tmp/*, is it really
>> necessary to do it in the stage2-preclean-chroot.sh script?
>>
>> -Tom Stellard
>>
>
>
> --
> Andrew Gaffney                                 http://dev.gentoo.org/~agaffney/
> Gentoo Linux Developer            Catalyst/Genkernel + Release Engineering Lead
>
>

I have filed a bug report:
http://bugs.gentoo.org/show_bug.cgi?id=264457

-Tom