Re: [gentoo-catalyst] [PATCH] modules/generic_target.py: Pass TERM through to the chroot environment

[Brian Dolbec]

On Sat, 2013-12-28 at 18:55 -0800, W. Trevor King wrote:
> From: "W. Trevor King" <wking@×××××××.us>
>
> Avoid:
>
>   Running stage1-chroot.sh in chroot /var/tmp/catalyst/tmp/default/...
>   tput: No value for $TERM and no -T specified
>
> by passing the caller's TERM environment variable [1] through to the
> chroot.  If the caller does not supply TERM, default to 'dumb' which
> disables color etc., but should be the most portable.  On Gentoo, the
> dumb terminfo (/usr/share/terminfo/d/dumb) is distributed as part of
> ncurses [2].  You can list supported terminals with toe, which is also
> distributed with ncurses [2]:
>
>   $ toe
>   ansi            ansi/pc-term compatible with color
>   dumb            80-column dumb tty
>   linux           linux console
>   ...
>
> [1]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03
> [2]: http://www.gnu.org/software/ncurses/
> ---
>  modules/generic_target.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/modules/generic_target.py b/modules/generic_target.py
> index fe96bd7..30dadc8 100644
> --- a/modules/generic_target.py
> +++ b/modules/generic_target.py
> @@ -1,3 +1,5 @@
> +import os
> +
>  from catalyst_support import *
>
>  class generic_target:
> @@ -7,5 +9,7 @@ class generic_target:
>  	def __init__(self,myspec,addlargs):
>  		addl_arg_parse(myspec,addlargs,self.required_values,self.valid_values)
>  		self.settings=myspec
> -		self.env={}
> -		self.env["PATH"]="/bin:/sbin:/usr/bin:/usr/sbin"
> +		self.env = {
> +			'PATH': '/bin:/sbin:/usr/bin:/usr/sbin',
> +			'TERM': os.getenv('TERM', 'dumb'),
> +			}

Hand applied to the 3.0 branch.  Works like a charm :)

Also will be pushed in the morning after a bit more testing which is in
progress.