1 |
On 16 Dec 2015 11:41, Kevin Zhao wrote: |
2 |
> - run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid "${clst_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs "zisofs" -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/ |
3 |
> + if [ "${clst_subarch}" == "ppc64le" ]||[ "${clst_subarch}" == "power8" ] |
4 |
|
5 |
please put spaces around the || operator, and use = instead of == |
6 |
|
7 |
isn't this power8 specific ? so do you really need to look at ppc64le ? |
8 |
|
9 |
> + then |
10 |
> + run_mkisofs -v -r -T -U -l -cache-inodes -chrp-boot -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}" |
11 |
> + else |
12 |
> + run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid "${clst_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs "zisofs" -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/ |
13 |
> + fi |
14 |
|
15 |
i know the existing code is ugly, but please fix that here. rather than |
16 |
duplicate the huge command line, factor out the common bits. something |
17 |
like: |
18 |
flags=( -r -U ) |
19 |
if [ "${clst_subarch}" = "power8" ] |
20 |
then |
21 |
flags+=( |
22 |
-v -T -l -cache-inodes -chrp-boot |
23 |
) |
24 |
else |
25 |
flags+=( |
26 |
... |
27 |
) |
28 |
fi |
29 |
run_mkisofs "${flags[@]}" \ |
30 |
-J ${mkisofs_zisofs_opts} |
31 |
-V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}" |
32 |
|
33 |
also, it seems like some of the flags you dropped for power8 should stay there. |
34 |
-mike |