Gentoo Archives: gentoo-catalyst

From: Felix Bier <Felix.Bier@×××××××××××××.com>
To: "gentoo-catalyst@l.g.o" <gentoo-catalyst@l.g.o>
Subject: [gentoo-catalyst] [PATCH 5/5] Drop PORTDIR from make.conf
Date: Thu, 04 Feb 2021 00:45:32
Message-Id: b4bc1967ff43662432629efba0d244d0defdf1f2.camel@rohde-schwarz.com
1 This commit drops PORTDIR from being included in the generated
2 make.conf. The variable is no longer needed, since the existing code
3 will now generate a repos.conf entry for the main repo when needed
4 (i.e. when the location is non-default, which is the same condition
5 that was applied for PORTDIR in the code removed by this commit).
6
7 The PORTDIR variable is considered deprecated in favor of
8 repos.conf entries (reference: https://wiki.gentoo.org/wiki/PORTDIR).
9
10 Signed-off-by: Felix Bier <felix.bier@×××××××××××××.com>
11 ---
12 These patches are intended for application top of 50ba8aad (current master).
13 To test for formatting issues, I sent the patches to myself, exported the mails
14 as mbox files and applied them with git am *mbox.
15
16 Best regards,
17 Felix
18
19 ---
20 catalyst/base/stagebase.py | 6 ------
21 1 file changed, 6 deletions(-)
22
23 diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
24 index 97e2318c..bc0eccd0 100644
25 --- a/catalyst/base/stagebase.py
26 +++ b/catalyst/base/stagebase.py
27 @@ -1092,12 +1092,6 @@ class StageBase(TargetBase, ClearBase, GenBase):
28 myf.write(hostuseexpand + '="' +
29 ' '.join(myuseexpandvars[hostuseexpand]) + '"\n')
30
31 - # Write non-default PORTDIR/DISTDIR/PKGDIR settings to make.conf
32 - if (self.settings['repo_basedir'], self.settings['repo_name']) != \
33 - (confdefaults['repo_basedir'], confdefaults['repo_name']):
34 - myf.write('PORTDIR="%s/%s"\n' % (self.settings['repo_basedir'],
35 - self.settings['repo_name']))
36 -
37 for x in ['target_distdir', 'target_pkgdir']:
38 if self.settings[x] != confdefaults[x]:
39 varname = x.split('_')[1].upper()
40 --
41 2.30.0

Replies

Subject Author
Re: [gentoo-catalyst] [PATCH 5/5] Drop PORTDIR from make.conf Matt Turner <mattst88@g.o>