| 1 |
On Sun, Mar 03, 2013 at 08:13:37AM -0800, Brian Dolbec wrote: |
| 2 |
> On Sun, 2013-03-03 at 08:01 -0500, W. Trevor King wrote: |
| 3 |
> > sshd_config lives in /etc/ssh, not /etc/sshd. This typo has been |
| 4 |
> > present since the block was introduced by c06264e (Initial import of |
| 5 |
> > Catalyst 2.0.0, 2005-04-04), so it's obviously not a widely used |
| 6 |
> > feature ;). It might be better to just remove the block entirely. |
| 7 |
> > --- |
| 8 |
> > … |
| 9 |
> It would be better to move the hard coding out of the bash script and |
| 10 |
> either into the config defaults or in this case (it's only used in the |
| 11 |
> one target) added to the target stage py file. In that way the default |
| 12 |
> value can be overwritten in the target spec file. |
| 13 |
|
| 14 |
I think I'd rather remove this block entirely. Adding a separate |
| 15 |
“enable root logins via SSH” option (and phase?) doesn't sound very |
| 16 |
appealing. This sort of thing is better suited to a per-user |
| 17 |
fsscript, especially if the in-catalyst support has always been |
| 18 |
broken. |
| 19 |
|
| 20 |
Cheers, |
| 21 |
Trevor |
| 22 |
|
| 23 |
-- |
| 24 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
| 25 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |
Archives