Gentoo Archives: gentoo-catalyst

From: Brian Dolbec <dolsen@g.o>
To: gentoo-catalyst@l.g.o
Subject: [gentoo-catalyst] [PATCH 6/8] Move generic_stage_targets.py constants to defaults.py
Date: Wed, 02 Apr 2014 20:30:23
Message-Id: 1396470583-8756-6-git-send-email-dolsen@gentoo.org
In Reply to: [gentoo-catalyst] [PATCH 2/8] Initial separation and creation of contents.py by Brian Dolbec
1 Rename the source and target mounts defaults to remove
2 the double plural.
3 ---
4 catalyst/defaults.py | 27 +++++++++++++++++++++++++
5 catalyst/targets/generic_stage_target.py | 34 ++++----------------------------
6 2 files changed, 31 insertions(+), 30 deletions(-)
7
8 diff --git a/catalyst/defaults.py b/catalyst/defaults.py
9 index b1dbda4..748d1dd 100644
10 --- a/catalyst/defaults.py
11 +++ b/catalyst/defaults.py
12 @@ -21,3 +21,30 @@ valid_config_file_values.extend(["PKGCACHE", "KERNCACHE", "CCACHE", "DISTCC",
13
14 verbosity = 1
15
16 +PORT_LOGDIR_CLEAN = \
17 + 'find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -delete'
18 +
19 +TARGET_MOUNT_DEFAULTS = {
20 + "ccache": "/var/tmp/ccache",
21 + "dev": "/dev",
22 + "devpts": "/dev/pts",
23 + "distdir": "/usr/portage/distfiles",
24 + "icecream": "/usr/lib/icecc/bin",
25 + "kerncache": "/tmp/kerncache",
26 + "packagedir": "/usr/portage/packages",
27 + "portdir": "/usr/portage",
28 + "port_tmpdir": "/var/tmp/portage",
29 + "port_logdir": "/var/log/portage",
30 + "proc": "/proc",
31 + "shm": "/dev/shm",
32 + }
33 +
34 +SOURCE_MOUNT_DEFAULTS = {
35 + "dev": "/dev",
36 + "devpts": "/dev/pts",
37 + "distdir": "/usr/portage/distfiles",
38 + "portdir": "/usr/portage",
39 + "port_tmpdir": "tmpfs",
40 + "proc": "/proc",
41 + "shm": "shmfs",
42 + }
43 diff --git a/catalyst/targets/generic_stage_target.py b/catalyst/targets/generic_stage_target.py
44 index de4842c..05c61e8 100644
45 --- a/catalyst/targets/generic_stage_target.py
46 +++ b/catalyst/targets/generic_stage_target.py
47 @@ -4,34 +4,8 @@ from generic_target import *
48 from stat import *
49 from catalyst.lock import LockDir
50
51 -
52 -PORT_LOGDIR_CLEAN = \
53 - 'find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -delete'
54 -
55 -TARGET_MOUNTS_DEFAULTS = {
56 - "ccache": "/var/tmp/ccache",
57 - "dev": "/dev",
58 - "devpts": "/dev/pts",
59 - "distdir": "/usr/portage/distfiles",
60 - "icecream": "/usr/lib/icecc/bin",
61 - "kerncache": "/tmp/kerncache",
62 - "packagedir": "/usr/portage/packages",
63 - "portdir": "/usr/portage",
64 - "port_tmpdir": "/var/tmp/portage",
65 - "port_logdir": "/var/log/portage",
66 - "proc": "/proc",
67 - "shm": "/dev/shm",
68 - }
69 -
70 -SOURCE_MOUNTS_DEFAULTS = {
71 - "dev": "/dev",
72 - "devpts": "/dev/pts",
73 - "distdir": "/usr/portage/distfiles",
74 - "portdir": "/usr/portage",
75 - "port_tmpdir": "tmpfs",
76 - "proc": "/proc",
77 - "shm": "shmfs",
78 - }
79 +from catalyst.defaults import (SOURCE_MOUNT_DEFAULTS, TARGET_MOUNT_DEFAULTS,
80 + PORT_LOGDIR_CLEAN)
81
82 # for convienience
83 pjoin = os.path.join
84 @@ -208,11 +182,11 @@ class generic_stage_target(generic_target):
85
86 """ Setup our mount points """
87 # initialize our target mounts.
88 - self.target_mounts = TARGET_MOUNTS_DEFAULTS.copy()
89 + self.target_mounts = TARGET_MOUNT_DEFAULTS.copy()
90
91 self.mounts = ["proc", "dev", "portdir", "distdir", "port_tmpdir"]
92 # initialize our source mounts
93 - self.mountmap = SOURCE_MOUNTS_DEFAULTS.copy()
94 + self.mountmap = SOURCE_MOUNT_DEFAULTS.copy()
95 # update them from settings
96 self.mountmap["distdir"] = self.settings["distdir"]
97 if "SNAPCACHE" not in self.settings:
98 --
99 1.8.5.3